error within transaction

Author: rez1dent3

changelog.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [8.2.0]
+### Added
+- Add exception `TransactionStartException`
+
 ## [8.1.1] - 2022-03-18
 ### Updated
 - Expanding the error description. Helps to reduce the number of issue.
@@ -815,7 +819,8 @@ The operation is now executed in the transaction and updates the new `refund` fi
 - Exceptions: AmountInvalid, BalanceIsEmpty.
 - Models: Transfer, Transaction.
 
-[Unreleased]: https://github.com/bavix/laravel-wallet/compare/8.1.1...develop
+[Unreleased]: https://github.com/bavix/laravel-wallet/compare/8.2.0...develop
+[8.2.0]: https://github.com/bavix/laravel-wallet/compare/8.1.1...8.2.0
 [8.1.1]: https://github.com/bavix/laravel-wallet/compare/8.1.0...8.1.1
 [8.1.0]: https://github.com/bavix/laravel-wallet/compare/8.0.6...8.1.0
 [8.0.6]: https://github.com/bavix/laravel-wallet/compare/8.0.5...8.0.6

docs/_sidebar.md

@@ -23,6 +23,10 @@
     - [Transfer](wallet-transfer)
     - [Transaction Filter](transaction-filter)
 
+- Nova
+
+    - [Change of balance](nova-action)
+
 - Purchases
 
     - [Payment](payment)

docs/nova-action.md

@@ -0,0 +1,26 @@
+## Nova Action
+
+As you know, the package works with internal state. You can read more [here](https://github.com/bavix/laravel-wallet/pull/412) and [here](https://github.com/bavix/laravel-wallet/issues/455).
+
+The action runs inside a transaction, which means you need to reset the transaction manually.
+
+```php
+use Illuminate\Support\Facades\DB;
+
+public function handle(ActionFields $fields, Collection $models)
+{
+    DB::rollBack(0);
+    ...
+}
+```
+
+Yes, it may not be convenient for someone, but you have to measure it. At the moment, there is no other solution.
+
+But what if you want to use a transaction?
+Use according to [documentation](transaction).
+
+Why was the decision made to move away from embedded transactions?
+The problem with embedded transactions is that the package changes the state of not only the database, but also the cache systems. Inside the transaction, sagas are implemented that update the balance in the cache systems of an already successful update inside the database.
+This feature was well described by me in the [pull request](https://github.com/bavix/laravel-wallet/pull/412).
+
+It worked! 

docs/transaction.md

@@ -1,5 +1,7 @@
 ## Transaction
 
+> Is it possible to use laravel's inline transactions? No, It is Immpossible. This limitation is due to the internal architecture of the package. To achieve the maximum speed of work, work with an internal state of balance was needed. Starting with version 8.2, a special error has appeared that will inform you about incorrect work with the `TransactionStartException` package.
+
 Sometimes you need to execute many simple queries. You want to keep the data atomic. To do this, you need `laravel-wallet` v7.1+.
 
 It is necessary to write off the amount from the balance and raise the ad in the search. What happens if the service for raising an ad fails? We wrote off the money, but did not raise the ad. Received reputational losses. We can imagine the opposite situation, we first raise the ad in the search, but it does not work to write off the money. There are not enough funds. This functionality will help to solve all this. We monitor ONLY the state of the wallet, the rest falls on the developer. Let's take an unsuccessful lift, for example.

src/Internal/Exceptions/ExceptionInterface.php

@@ -21,4 +21,5 @@ interface ExceptionInterface extends Throwable
     public const TRANSACTION_FAILED = 1 << 10;
     public const MODEL_NOT_FOUND = 1 << 11;
     public const UNKNOWN_EVENT = 1 << 12;
+    public const TRANSACTION_START = 1 << 13;
 }

src/Internal/Exceptions/TransactionStartException.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Bavix\Wallet\Internal\Exceptions;
+
+use LogicException;
+
+final class TransactionStartException extends LogicException implements LogicExceptionInterface
+{
+}

src/Internal/Service/DatabaseService.php

@@ -6,6 +6,7 @@
 
 use Bavix\Wallet\Internal\Exceptions\ExceptionInterface;
 use Bavix\Wallet\Internal\Exceptions\TransactionFailedException;
+use Bavix\Wallet\Internal\Exceptions\TransactionStartException;
 use Bavix\Wallet\Services\RegulatorServiceInterface;
 use Illuminate\Config\Repository as ConfigRepository;
 use Illuminate\Database\ConnectionInterface;
@@ -17,6 +18,8 @@ final class DatabaseService implements DatabaseServiceInterface
 {
     private ConnectionInterface $connection;
 
+    private bool $init = false;
+
     public function __construct(
         ConnectionResolverInterface $connectionResolver,
         private RegulatorServiceInterface $regulatorService,
@@ -34,15 +37,27 @@ public function __construct(
      */
     public function transaction(callable $callback)
     {
+        $level = $this->connection->transactionLevel();
+        if ($level > 0 && !$this->init) {
+            throw new TransactionStartException(
+                'Working inside an embedded transaction is not possible. https://bavix.github.io/laravel-wallet/#/transaction',
+                ExceptionInterface::TRANSACTION_START,
+            );
+        }
+
+        $this->init = true;
+
         try {
-            if ($this->connection->transactionLevel() > 0) {
+            if ($level > 0) {
                 return $callback();
             }
 
             $this->regulatorService->purge();
 
             return $this->connection->transaction(function () use ($callback) {
                 $result = $callback();
+                $this->init = false;
+
                 if ($result === false || (is_countable($result) && count($result) === 0)) {
                     $this->regulatorService->purge();
                 } else {
@@ -53,10 +68,12 @@ public function transaction(callable $callback)
             });
         } catch (RecordsNotFoundException|ExceptionInterface $exception) {
             $this->regulatorService->purge();
+            $this->init = false;
 
             throw $exception;
         } catch (Throwable $throwable) {
             $this->regulatorService->purge();
+            $this->init = false;
 
             throw new TransactionFailedException(
                 'Transaction failed. Message: '.$throwable->getMessage(),

src/Internal/Service/DatabaseServiceInterface.php

@@ -6,12 +6,14 @@
 
 use Bavix\Wallet\Internal\Exceptions\ExceptionInterface;
 use Bavix\Wallet\Internal\Exceptions\TransactionFailedException;
+use Bavix\Wallet\Internal\Exceptions\TransactionStartException;
 use Illuminate\Database\RecordsNotFoundException;
 
 interface DatabaseServiceInterface
 {
     /**
      * @throws RecordsNotFoundException
+     * @throws TransactionStartException
      * @throws TransactionFailedException
      * @throws ExceptionInterface
      *

tests/Units/Service/DatabaseTest.php

@@ -6,14 +6,19 @@
 
 use Bavix\Wallet\Internal\Exceptions\ExceptionInterface;
 use Bavix\Wallet\Internal\Exceptions\TransactionFailedException;
+use Bavix\Wallet\Internal\Exceptions\TransactionStartException;
 use Bavix\Wallet\Internal\Service\DatabaseServiceInterface;
 use Bavix\Wallet\Test\Infra\TestCase;
+use Illuminate\Support\Facades\DB;
 
 /**
  * @internal
  */
 final class DatabaseTest extends TestCase
 {
+    /**
+     * @throws ExceptionInterface
+     */
     public function testCheckCode(): void
     {
         $this->expectException(TransactionFailedException::class);
@@ -23,4 +28,16 @@ public function testCheckCode(): void
             throw new \RuntimeException();
         });
     }
+
+    /**
+     * @throws ExceptionInterface
+     */
+    public function testCheckInTransaction(): void
+    {
+        $this->expectException(TransactionStartException::class);
+        $this->expectExceptionCode(ExceptionInterface::TRANSACTION_START);
+
+        DB::beginTransaction();
+        app(DatabaseServiceInterface::class)->transaction(static fn (): int => 42);
+    }
 }