optimize addBalance

Author: rez1dent3

src/Services/CommonServiceLegacy.php

@@ -13,7 +13,6 @@
 use Bavix\Wallet\Internal\Exceptions\RecordNotFoundException;
 use Bavix\Wallet\Internal\Exceptions\TransactionFailedException;
 use Bavix\Wallet\Internal\Service\DatabaseServiceInterface;
-use Bavix\Wallet\Internal\Service\MathServiceInterface;
 use Bavix\Wallet\Models\Transaction;
 use Bavix\Wallet\Models\Transfer;
 use Bavix\Wallet\Models\Wallet as WalletModel;
@@ -30,7 +29,6 @@ final class CommonServiceLegacy
     private RegulatorServiceInterface $regulatorService;
     private TransferDtoAssemblerInterface $transferDtoAssembler;
     private StateServiceInterface $stateService;
-    private MathServiceInterface $mathService;
 
     public function __construct(
         CastServiceInterface $castService,
@@ -40,8 +38,7 @@ public function __construct(
         TransferDtoAssemblerInterface $transferDtoAssembler,
         RegulatorServiceInterface $regulatorService,
         StateServiceInterface $stateService,
-        AtmServiceInterface $atmService,
-        MathServiceInterface $mathService
+        AtmServiceInterface $atmService
     ) {
         $this->atmService = $atmService;
         $this->castService = $castService;
@@ -51,7 +48,6 @@ public function __construct(
         $this->regulatorService = $regulatorService;
         $this->transferDtoAssembler = $transferDtoAssembler;
         $this->stateService = $stateService;
-        $this->mathService = $mathService;
     }
 
     /**
@@ -147,11 +143,11 @@ public function addBalance(Wallet $wallet, $amount): bool
                     ->whereKey($walletObject->getKey())
                     ->update(['balance' => $balance])
                 ;
-
-                $walletObject->fill(['balance' => $balance])->syncOriginalAttribute('balance');
             } finally {
                 if ($result === 0) {
-                    $this->regulatorService->increase($walletObject, $this->mathService->negative($amount));
+                    $this->regulatorService->decrease($walletObject, $amount);
+                } else {
+                    $walletObject->fill(['balance' => $balance])->syncOriginalAttribute('balance');
                 }
             }
 

src/Services/RegulatorService.php

@@ -74,6 +74,12 @@ public function increase(Wallet $wallet, $value): string
         }
     }
 
+    /** @param float|int|string $value */
+    public function decrease(Wallet $wallet, $value): string
+    {
+        return $this->increase($wallet, $this->mathService->negative($value));
+    }
+
     private function getKey(string $uuid): string
     {
         return $this->idempotentKey.'::'.$uuid;

src/Services/RegulatorServiceInterface.php

@@ -19,4 +19,7 @@ public function sync(Wallet $wallet, $value): bool;
 
     /** @param float|int|string $value */
     public function increase(Wallet $wallet, $value): string;
+
+    /** @param float|int|string $value */
+    public function decrease(Wallet $wallet, $value): string;
 }

tests/Units/Domain/CartTest.php

@@ -254,6 +254,7 @@ public function testBoughtGoods(): void
     public function testWithdrawal(): void
     {
         $transactionLevel = Buyer::query()->getConnection()->transactionLevel();
+        self::assertSame(0, $transactionLevel);
 
         /**
          * @var Buyer $buyer