AtomicServiceInterface doesn't rollback on exception?

[JavierFerrerGomez]

I didn't open this as an issue because I am not sure I understood how AtomicServiceInterface should work. If this is indeed a bug I will open an issue with a proper working test case.

When using AtomicServiceInterface I am expecting that in the case of an exception all operations already applied to the DB will be rollbacked, but that is not the case. This is the relevant code in my user model:

class User extends Authenticatable implements MustVerifyEmail
{
    use HasApiTokens;
    use HasFactory;
    use Notifiable;
    use HasWallets;

    public function depositWalletTransaction(
        int $amount,
        string $slug,
        callable $onSuccessFn = null
    ) {

        $wallet = $this->getWallet($slug);
        app(AtomicServiceInterface::class)->block($wallet, function () use ($wallet, $amount, $onSuccessFn) {
            $walletTransaction = $wallet->deposit($amount);
            if ($onSuccessFn) {
                $onSuccessFn($walletTransaction);
            }
        });
    }
}

Then in my test case I have:

    #[Test]
    public function transaction_deposit_should_rollback(): void
    {
        $user = $this->getTestUser(); // balance here is 10000

        try {            
            $user->depositWalletTransaction(10, "global", function ($transaction) use ($user) {
                $user->email = "[email protected]";
                $user->save();
                throw new GameWalletException('ERROR!');
            });
        } catch(\Exception $e) {
            $this->assertInstanceOf(GameWalletException::class, $e);
            $user = User::find(1)->first();
            assertEquals(10000, $user->getConfirmedGlobalBalanceInt());
            assertEquals('[email protected]', $user->email);
        }
    }

When I runt the test, in my catch statement the current balance is 10010 (getConfirmedGlobalBalanceInt calls refreshBalance internally) and the email address is [email protected]. What am I missing?

[rez1dent3]

Hello. I checked it. Everything works as expected. Here is the PR: https://github.com/bavix/laravel-wallet/pull/977/files

I am 99.99% sure that a transaction is created before your test and atomic does not create a new one. I suggest you add a check that the transaction level is zero.

Example:

    #[Test]
    public function transaction_deposit_should_rollback(): void
    {
+        self::assertSame(0, \Illuminate\Support\Facades\DB::transactionLevel());

I think the test will start to fail on this line.