Skip to content

Conversation

@LarsKue
Copy link
Contributor

@LarsKue LarsKue commented Apr 8, 2025

Fixes #249

@LarsKue LarsKue added feature New feature or request user interface Changes to the user interface and improvements in usability sugar Syntactical sugar or quality of life improvements labels Apr 8, 2025
@LarsKue LarsKue added this to the BayesFlow 2.0 milestone Apr 8, 2025
@LarsKue LarsKue self-assigned this Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bayesflow/adapters/adapter.py 16.66% 5 Missing ⚠️
bayesflow/utils/empty.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
bayesflow/adapters/transforms/filter_transform.py 70.87% <ø> (ø)
bayesflow/utils/empty.py 0.00% <0.00%> (ø)
bayesflow/adapters/adapter.py 80.44% <16.66%> (-2.22%) ⬇️

@LarsKue LarsKue changed the base branch from main to dev April 8, 2025 20:15
@LarsKue LarsKue marked this pull request as ready for review April 8, 2025 20:22
@LarsKue LarsKue requested a review from Copilot April 8, 2025 20:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

bayesflow/utils/empty.py:1

  • Class names should follow CamelCase conventions. Consider renaming 'empty' to 'Empty'.
class empty:

@LarsKue LarsKue merged commit 9853265 into dev Apr 8, 2025
14 of 15 checks passed
@LarsKue LarsKue deleted the allow-positional-include-transforms branch April 8, 2025 20:23
@github-project-automation github-project-automation bot moved this from Future to Done in bayesflow development Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request sugar Syntactical sugar or quality of life improvements user interface Changes to the user interface and improvements in usability

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Allow positional include args for FilterTransforms in Adapter

2 participants