Serialization of TimeSeriesTransformer
#424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deserialization of the `TimeSeriesTransformer` is broken, but it went undetected as this network is not included in the tests yet. This commit adds the network, but does not resolve the deserialization problems yet. Regards bayesflow-org#423
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Collaborator
Author
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is intended as a place to fix the deserialization of the
TimeSeriesTransformer, described in #423.The deserialization of the
TimeSeriesTransformeris broken, but it went undetected as this network is not included in the tests yet. I already added the test, but have no fix yet. I suggest we try to come up with a fix quickly and then merge tests and fix intodevtogether.