Disable SDR when non-float parameters are present

Author: till-m

bayes_opt/domain_reduction.py

@@ -14,6 +14,7 @@
 
 import numpy as np
 
+from bayes_opt.parameter import FloatParameter
 from bayes_opt.target_space import TargetSpace
 
 if TYPE_CHECKING:
@@ -90,6 +91,10 @@ def initialize(self, target_space: TargetSpace) -> None:
         target_space : TargetSpace
             TargetSpace this DomainTransformer operates on.
         """
+        any_not_float = any([not isinstance(p, FloatParameter) for p in target_space._params_config.values()])
+        if any_not_float:
+            msg = "Domain reduction is only supported for all-FloatParameter optimization."
+            raise ValueError(msg)
         # Set the original bounds
         self.original_bounds = np.copy(target_space.bounds)
         self.bounds = [self.original_bounds]

tests/test_seq_domain_red.py

@@ -179,6 +179,14 @@ def test_minimum_window_dict_ordering():
     )
 
 
+def test_mixed_parameters():
+    """Ensure that the transformer errors when providing non-float parameters"""
+    pbounds = {"x": (-10, 10), "y": (-10, 10), "z": (1, 10, int)}
+    target_space = TargetSpace(target_func=black_box_function, pbounds=pbounds)
+    with pytest.raises(ValueError):
+        _ = SequentialDomainReductionTransformer().initialize(target_space)
+
+
 if __name__ == "__main__":
     r"""
     CommandLine: