remove duplicate acquisition functions random state

Author: adrianmolzon

bayes_opt/acquisition.py

@@ -1221,8 +1221,7 @@ def get_acquisition_params(self) -> dict:
             "previous_candidates": self.previous_candidates.tolist()
             if self.previous_candidates is not None
             else None,
-            "random_states": [acq._serialize_random_state() for acq in self.base_acquisitions]
-            + [self._serialize_random_state()],
+            "gphedge_random_state": self._serialize_random_state(),
         }
 
     def set_acquisition_params(self, params: dict) -> None:
@@ -1233,15 +1232,14 @@ def set_acquisition_params(self, params: dict) -> None:
         params : dict
             Dictionary containing the acquisition function parameters.
         """
-        for acq, acq_params, random_state in zip(
-            self.base_acquisitions, params["base_acquisitions_params"], params["random_states"][:-1]
+        for acq, acq_params in zip(
+            self.base_acquisitions, params["base_acquisitions_params"]
         ):
             acq.set_acquisition_params(acq_params)
-            acq._deserialize_random_state(random_state)
 
         self.gains = np.array(params["gains"])
         self.previous_candidates = (
             np.array(params["previous_candidates"]) if params["previous_candidates"] is not None else None
         )
 
-        self._deserialize_random_state(params["random_states"][-1])
+        self._deserialize_random_state(params["gphedge_random_state"])

tests/test_acquisition.py

@@ -596,3 +596,45 @@ def test_integration_constrained(target_func_x_and_y, pbounds, constraint, tmp_p
     new_optimizer.load_state(state_path)
 
     verify_optimizers_match(optimizer, new_optimizer)
+
+
+def test_custom_acquisition_without_get_params():
+    """Test that a custom acquisition function without get_acquisition_params raises NotImplementedError."""
+
+    class CustomAcqWithoutGetParams(acquisition.AcquisitionFunction):
+        def __init__(self, random_state=None):
+            super().__init__(random_state=random_state)
+
+        def base_acq(self, mean, std):
+            return mean + std
+
+        def set_acquisition_params(self, params):
+            pass
+
+    acq = CustomAcqWithoutGetParams()
+    with pytest.raises(
+        NotImplementedError,
+        match="Custom AcquisitionFunction subclasses must implement their own get_acquisition_params method",
+    ):
+        acq.get_acquisition_params()
+
+
+def test_custom_acquisition_without_set_params():
+    """Test that a custom acquisition function without set_acquisition_params raises NotImplementedError."""
+
+    class CustomAcqWithoutSetParams(acquisition.AcquisitionFunction):
+        def __init__(self, random_state=None):
+            super().__init__(random_state=random_state)
+
+        def base_acq(self, mean, std):
+            return mean + std
+
+        def get_acquisition_params(self):
+            return {}
+
+    acq = CustomAcqWithoutSetParams()
+    with pytest.raises(
+        NotImplementedError,
+        match="Custom AcquisitionFunction subclasses must implement their own set_acquisition_params method",
+    ):
+        acq.set_acquisition_params(params={})