Skip to content

Commit 6edcb2a

Browse files
committed
format parameter values correctly
1 parent d115fc1 commit 6edcb2a

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

bayes_opt/logger.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ def _format_str(self, str_: str) -> str:
139139

140140
def _print_step(
141141
self,
142-
result: dict[str, Any],
143142
keys: list[str],
143+
result: dict[str, Any],
144144
params_config: Mapping[str, ParameterConfig],
145145
colour: str = _colour_regular_message,
146146
) -> str:
@@ -173,9 +173,11 @@ def _print_step(
173173
cells[2] = self._format_bool(result["allowed"])
174174
params = result.get("params", {})
175175
cells[3:] = [
176-
params_config[key].to_string(val, self._default_cell_size) for key, val in params.items()
176+
self._format_number(val)
177+
if isinstance(val, (int, float))
178+
else params_config[key].to_string(val, self._default_cell_size)
179+
for key, val in params.items()
177180
]
178-
179181
return "| " + " | ".join(colour + x + self._colour_reset for x in cells if x is not None) + " |"
180182

181183
def _print_header(self, keys: list[str]) -> str:
@@ -282,7 +284,7 @@ def log_optimization_step(
282284

283285
if self._verbose == 2 or is_new_max:
284286
colour = self._colour_new_max if is_new_max else self._colour_regular_message
285-
line = self._print_step(result, keys, params_config, colour=colour) + "\n"
287+
line = self._print_step(keys, result, params_config, colour=colour) + "\n"
286288
if self._verbose:
287289
print(line, end="")
288290

tests/test_logger.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def test_step():
148148

149149
# Test default color
150150
step_str = logger._print_step(
151-
optimizer._space.res()[-1], optimizer._space.keys, optimizer._space.params_config
151+
optimizer._space.keys, optimizer._space.res()[-1], optimizer._space.params_config
152152
)
153153
assert "|" in step_str
154154
assert "1" in step_str # iteration
@@ -157,7 +157,7 @@ def test_step():
157157
# Test with custom color
158158
custom_color = Fore.RED
159159
step_str_colored = logger._print_step(
160-
optimizer._space.res()[-1], optimizer._space.keys, optimizer._space.params_config, colour=custom_color
160+
optimizer._space.keys, optimizer._space.res()[-1], optimizer._space.params_config, colour=custom_color
161161
)
162162
assert custom_color in step_str_colored
163163

0 commit comments

Comments
 (0)