Fix constraint probability checking wrong bound (#555)

till-m · web-flow · commit aa9d0184322c · 2025-03-13T10:11:20.000+01:00
diff --git a/bayes_opt/constraint.py b/bayes_opt/constraint.py
@@ -203,7 +203,7 @@ def predict(self, X: NDArray[Float]) -> NDArray[Float]:
                 norm(loc=y_mean, scale=y_std).cdf(self._lb[0]) if self._lb[0] != -np.inf else np.array([0])
             )
             p_upper = (
-                norm(loc=y_mean, scale=y_std).cdf(self._ub[0]) if self._lb[0] != np.inf else np.array([1])
+                norm(loc=y_mean, scale=y_std).cdf(self._ub[0]) if self._ub[0] != np.inf else np.array([1])
             )
             result = p_upper - p_lower
             return result.reshape(X_shape[:-1])
@@ -215,7 +215,7 @@ def predict(self, X: NDArray[Float]) -> NDArray[Float]:
                 norm(loc=y_mean, scale=y_std).cdf(self._lb[j]) if self._lb[j] != -np.inf else np.array([0])
             )
             p_upper = (
-                norm(loc=y_mean, scale=y_std).cdf(self._ub[j]) if self._lb[j] != np.inf else np.array([1])
+                norm(loc=y_mean, scale=y_std).cdf(self._ub[j]) if self._ub[j] != np.inf else np.array([1])
             )
             result = result * (p_upper - p_lower)
         return result.reshape(X_shape[:-1])

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ def predict(self, X: NDArray[Float]) -> NDArray[Float]:`
`203`	`203`	`norm(loc=y_mean, scale=y_std).cdf(self._lb[0]) if self._lb[0] != -np.inf else np.array([0])`
`204`	`204`	`)`
`205`	`205`	`p_upper = (`
`206`		`- norm(loc=y_mean, scale=y_std).cdf(self._ub[0]) if self._lb[0] != np.inf else np.array([1])`
	`206`	`+ norm(loc=y_mean, scale=y_std).cdf(self._ub[0]) if self._ub[0] != np.inf else np.array([1])`
`207`	`207`	`)`
`208`	`208`	`result = p_upper - p_lower`
`209`	`209`	`return result.reshape(X_shape[:-1])`
`@@ -215,7 +215,7 @@ def predict(self, X: NDArray[Float]) -> NDArray[Float]:`
`215`	`215`	`norm(loc=y_mean, scale=y_std).cdf(self._lb[j]) if self._lb[j] != -np.inf else np.array([0])`
`216`	`216`	`)`
`217`	`217`	`p_upper = (`
`218`		`- norm(loc=y_mean, scale=y_std).cdf(self._ub[j]) if self._lb[j] != np.inf else np.array([1])`
	`218`	`+ norm(loc=y_mean, scale=y_std).cdf(self._ub[j]) if self._ub[j] != np.inf else np.array([1])`
`219`	`219`	`)`
`220`	`220`	`result = result * (p_upper - p_lower)`
`221`	`221`	`return result.reshape(X_shape[:-1])`