Typed Optimization #531
Merged
Typed Optimization #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: import error from exception module (bayesian-optimization#525) * fix: replace list with sequence (bayesian-optimization#524) * Fix min window type check (bayesian-optimization#523) * fix: replace dict with Mapping * fix: replace list with Sequence * fix: add type hint * fix: does not accept None * Change docs badge (bayesian-optimization#527) * fix: parameter, target_space * fix: constraint, bayesian_optimization * fix: ParamsType --------- Co-authored-by: till-m <[email protected]>
bwheelz36
reviewed
Nov 16, 2024
bwheelz36
approved these changes
Nov 16, 2024
Collaborator
bwheelz36
left a comment
bwheelz36
left a comment
There was a problem hiding this comment.
Great work! this is very cool
- minor: in the new notebook, might be nice to add type hints, particularly to show that
target_function_1d(x)-> int
Member
Author
|
Thanks for the review! Once I have some time to finish the custom parameter example, this would be ready for merging. NB: I might also handle #530 with this PR, as it's technically already implemented here. |
Member
Author
|
@bwheelz36 I added an example with a custom parameter, if you get the chance it'd be great if you could have a look |
Member
Author
|
@phi-friday could you have another look over this PR and check if the typing is implemented correctly? |
Member
Author
|
I think from my side this is done. I'm looking to merge this pretty soon and make a release after. Apparently you can do beta releases which might make sense here. |
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #93 #191 #308 #376
Implement typed optimization as described in ref. For an example, see the notebook and also
examples/typed_hyperparameter_tuning.py. Some evidence that this can be valuable: