refactor: delete stardoc_with_diff_test (#1188)

The stardoc module has heavy dependencies. See remaining justification
in the attached issue.

Fixes #1185

BREAKING CHANGE: bazel-lib no longer provides a convenience for checking
in generated docs. Alternatives:
- (recommended): publish `starlark_doc_extract` rules on releases
instead of checking in generated files; see
https://blog.aspect.build/stardocs-on-bcr
- Copy the macro into your own repo like rules_go does, combining a
stardoc target with a `diff_test`
- Use `aspect_bazel_lib` 2.x along with `bazel_lib`; the former provides
this rule.

Author: alexeagle

.bazelignore

@@ -1,3 +1,2 @@
 # nested modules
-docs/
 e2e/

.github/workflows/release_prep.sh

@@ -46,7 +46,7 @@ SHA=$(shasum -a 256 $ARCHIVE | awk '{print $1}')
 # Add generated API docs to the release, see https://github.com/bazelbuild/bazel-central-registry/issues/5593
 docs="$(mktemp -d)"; targets="$(mktemp)"
 bazel --output_base="$docs" query --output=label --output_file="$targets" 'kind("starlark_doc_extract rule", //...)'
-bazel --output_base="$docs" build --target_pattern_file="$targets" --remote_download_regex='.*doc_extract\.binaryproto'
+bazel --output_base="$docs" build --target_pattern_file="$targets"
 tar --create --auto-compress \
     --directory "$(bazel --output_base="$docs" info bazel-bin)" \
     --file "$GITHUB_WORKSPACE/${ARCHIVE%.tar.gz}.docs.tar.gz" .

.pre-commit-config.yaml

@@ -32,7 +32,7 @@ repos:
       - id: check-symlinks
       - id: destroyed-symlinks
       - id: end-of-file-fixer
-        exclude: &exclude_pattern "^(docs|e2e|lib/tests)/"
+        exclude: "^(e2e|lib/tests)/"
       - id: mixed-line-ending
       - id: trailing-whitespace
   - repo: https://github.com/crate-ci/typos

.prettierignore

@@ -1,6 +1,4 @@
 .circleci/config.yml
-docs/*.md
-e2e/*/docs.md
 lib/lib/tests/write_source_files/*.js
 lib/lib/tests/write_source_files/subdir/*.js
 lib/lib/tests/write_source_files/subdir/subsubdir/*.js

MODULE.bazel

@@ -8,7 +8,6 @@ module(
 bazel_dep(name = "bazel_features", version = "1.9.0")
 bazel_dep(name = "bazel_skylib", version = "1.8.1")
 bazel_dep(name = "platforms", version = "0.0.10")
-bazel_dep(name = "stardoc", version = "0.7.1")
 bazel_dep(name = "rules_shell", version = "0.4.1")
 
 bazel_lib_toolchains = use_extension("@bazel_lib//lib:extensions.bzl", "toolchains")

e2e/api_entries/BUILD.bazel

@@ -18,7 +18,6 @@ build_test(
         "@bazel_lib//lib:coreutils_toolchain_type",
         "@bazel_lib//lib:diff_test",
         "@bazel_lib//lib:directory_path",
-        "@bazel_lib//lib:docs",
         "@bazel_lib//lib:enable_runfiles",
         "@bazel_lib//lib:expand_make_vars",
         "@bazel_lib//lib:expand_template",

lib/BUILD.bazel

@@ -1,9 +1,8 @@
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
 load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
+load("//:bzl_library.bzl", "bzl_library")
 load("//lib:utils.bzl", "is_bzlmod_enabled")
 load("//lib/private:stamping.bzl", "stamp_build_setting")
 
-# Ensure that users building their own rules can dep on our bzl_library targets for their stardoc
 package(default_visibility = ["//visibility:public"])
 
 exports_files(
@@ -262,12 +261,6 @@ bzl_library(
     deps = ["//lib/private:lists"],
 )
 
-bzl_library(
-    name = "docs",
-    srcs = ["docs.bzl"],
-    deps = ["//lib/private:docs"],
-)
-
 bzl_library(
     name = "windows_utils",
     srcs = ["windows_utils.bzl"],

lib/docs.bzl

@@ -109,16 +109,6 @@ bzl_library(
     ],
 )
 
-bzl_library(
-    name = "docs",
-    srcs = ["docs.bzl"],
-    visibility = ["//lib:__subpackages__"],
-    deps = [
-        "//lib:write_source_files",
-        "@stardoc//stardoc:stardoc_lib",  #keep
-    ],
-)
-
 bzl_library(
     name = "expand_template",
     srcs = ["expand_template.bzl"],