chore: add linting to ci (#208)

Author: kormide

.aspect/workflows/config.yaml

@@ -1,7 +1,7 @@
 # See https://docs.aspect.build/workflows/configuration
 tasks:
-  # - format:
-  #       queue: aspect-medium
+  - format:
+      queue: aspect-medium
   - buildifier:
       queue: aspect-medium
   - configure:

.pre-commit-config.yaml

@@ -1,7 +1,6 @@
 # Commitizen runs in commit-msg stage
 # but we don't want to run the other hooks on commit messages
 default_stages: [commit]
-
 repos:
   # Enforce that commit messages allow for later changelog generation
   - repo: https://github.com/commitizen-tools/commitizen
@@ -10,13 +9,13 @@ repos:
       # Requires that commitizen is already installed
       - id: commitizen
         stages: [commit-msg]
-  - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: 'v2.7.1'
+  - repo: local
     hooks:
-      - id: prettier
-        additional_dependencies:
-          - [email protected]
-          - [email protected]
+      - id: format
+        name: Format
+        language: system
+        entry: bazel run //:format
+        files: .*
   - repo: https://github.com/keith/pre-commit-buildifier
     rev: 8.0.0
     hooks:

.prettierrc.cjs

@@ -1,16 +1,16 @@
 /* eslint-env node */
 
 module.exports = {
-    trailingComma: 'es5',
-    tabWidth: 4,
-    semi: true,
-    singleQuote: true,
-    overrides: [
-        {
-            files: ['**/*.yaml', '**/*.yml', '**/*.json'],
-            options: {
-                tabWidth: 2,
-            },
-        },
-    ],
+  trailingComma: 'es5',
+  tabWidth: 2,
+  semi: true,
+  singleQuote: true,
+  overrides: [
+    {
+      files: ['**/*.tf', '**/*.yaml', '**/*.yml', '**/*.json'],
+      options: {
+        tabWidth: 2,
+      },
+    },
+  ],
 };

deployment/environments/dev/backend.tf

@@ -1,6 +1,6 @@
 terraform {
- backend "gcs" {
-   bucket  = "bucket-tfstate-1c526cd61f0c2662"
-   prefix  = "terraform/state"
- }
+  backend "gcs" {
+    bucket = "bucket-tfstate-1c526cd61f0c2662"
+    prefix = "terraform/state"
+  }
 }

deployment/environments/dev/main.tf

@@ -4,13 +4,13 @@ provider "google" {
 }
 
 module "webhook" {
-    source = "../../modules/webhook"
+  source = "../../modules/webhook"
 
-    github_app_id =  "221842"
-    github_bot_app_id =  "228146"
-    bazel_central_registry = "publish-to-bcr-dev-registry/bazel-central-registry"
-    notifications_email = "[email protected]"
-    debug_email = "[email protected]"
-    smtp_host = "in-v3.mailjet.com"
-    smtp_port = 465
+  github_app_id          = "221842"
+  github_bot_app_id      = "228146"
+  bazel_central_registry = "publish-to-bcr-dev-registry/bazel-central-registry"
+  notifications_email    = "[email protected]"
+  debug_email            = "[email protected]"
+  smtp_host              = "in-v3.mailjet.com"
+  smtp_port              = 465
 }

deployment/environments/prod/backend.tf

@@ -1,6 +1,6 @@
 terraform {
- backend "gcs" {
-   bucket  = "bucket-tfstate-02793625b05b4e9a"
-   prefix  = "terraform/state"
- }
+  backend "gcs" {
+    bucket = "bucket-tfstate-02793625b05b4e9a"
+    prefix = "terraform/state"
+  }
 }

deployment/environments/prod/main.tf

@@ -5,13 +5,13 @@ provider "google" {
 }
 
 module "webhook" {
-    source = "../../modules/webhook"
+  source = "../../modules/webhook"
 
-    github_app_id =  "196878"
-    github_bot_app_id =  "234555"
-    bazel_central_registry = "bazelbuild/bazel-central-registry"
-    notifications_email = "[email protected]"
-    debug_email = "[email protected]"
-    smtp_host = "in-v3.mailjet.com"
-    smtp_port = 465
+  github_app_id          = "196878"
+  github_bot_app_id      = "234555"
+  bazel_central_registry = "bazelbuild/bazel-central-registry"
+  notifications_email    = "[email protected]"
+  debug_email            = "[email protected]"
+  smtp_host              = "in-v3.mailjet.com"
+  smtp_port              = 465
 }

deployment/modules/remote-state/main.tf

@@ -1,7 +1,7 @@
 terraform {
   required_providers {
     google = {
-      source = "hashicorp/google"
+      source  = "hashicorp/google"
       version = "4.84.0"
     }
   }
@@ -17,7 +17,7 @@ resource "random_id" "instance_id" {
 }
 
 resource "google_storage_bucket" "remote_state_bucket" {
-  name = "bucket-tfstate-${random_id.instance_id.hex}"
+  name          = "bucket-tfstate-${random_id.instance_id.hex}"
   force_destroy = false
   location      = var.region
   storage_class = "STANDARD"

deployment/modules/remote-state/variables.tf

@@ -1,10 +1,10 @@
 variable "project_id" {
-    type = string
-    description = "ID of the Google Cloud project in which to create the terraform state bucket"
+  type        = string
+  description = "ID of the Google Cloud project in which to create the terraform state bucket"
 }
 
 variable "region" {
-    type = string
-    description = "Google Cloud region to deploy resources to"
-    default = "us-west1"
+  type        = string
+  description = "Google Cloud region to deploy resources to"
+  default     = "us-west1"
 }

deployment/modules/webhook/main.tf

@@ -2,7 +2,7 @@
 terraform {
   required_providers {
     google = {
-      source = "hashicorp/google"
+      source  = "hashicorp/google"
       version = "4.84.0"
     }
   }
@@ -12,7 +12,7 @@ data "google_client_config" "this" {}
 
 locals {
   project = var.project != null ? var.project : data.google_client_config.this.project
-  region =  var.region != null ? var.region : data.google_client_config.this.region
+  region  = var.region != null ? var.region : data.google_client_config.this.region
 }
 
 resource "google_storage_bucket" "source_archive_bucket" {
@@ -31,23 +31,23 @@ resource "google_cloudfunctions_function" "publish_to_bcr_function" {
   description = "Handle incoming github events"
   runtime     = "nodejs20"
 
-  available_memory_mb   = 1024
-  source_archive_bucket = google_storage_bucket.source_archive_bucket.name
-  source_archive_object = google_storage_bucket_object.publish_to_bcr_function_bucket_object.name
-  trigger_http          = true
+  available_memory_mb          = 1024
+  source_archive_bucket        = google_storage_bucket.source_archive_bucket.name
+  source_archive_object        = google_storage_bucket_object.publish_to_bcr_function_bucket_object.name
+  trigger_http                 = true
   https_trigger_security_level = "SECURE_ALWAYS"
-  ingress_settings = "ALLOW_ALL"
-  entry_point           = "handleGithubWebhookEvent"
-  timeout = 240
+  ingress_settings             = "ALLOW_ALL"
+  entry_point                  = "handleGithubWebhookEvent"
+  timeout                      = 240
 
   environment_variables = {
-    GITHUB_APP_ID = var.github_app_id,
-    GITHUB_BOT_APP_ID = var.github_bot_app_id,
+    GITHUB_APP_ID          = var.github_app_id,
+    GITHUB_BOT_APP_ID      = var.github_bot_app_id,
     BAZEL_CENTRAL_REGISTRY = var.bazel_central_registry,
-    NOTIFICATIONS_EMAIL = var.notifications_email,
-    DEBUG_EMAIL = var.debug_email,
-    SMTP_HOST = var.smtp_host,
-    SMTP_PORT = var.smtp_port,
+    NOTIFICATIONS_EMAIL    = var.notifications_email,
+    DEBUG_EMAIL            = var.debug_email,
+    SMTP_HOST              = var.smtp_host,
+    SMTP_PORT              = var.smtp_port,
   }
 }
 
@@ -75,9 +75,9 @@ resource "google_secret_manager_secret" "github_app_webhook_secret" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "github_app_webhook_secret_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.github_app_webhook_secret.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]
@@ -96,9 +96,9 @@ resource "google_secret_manager_secret" "github_app_private_key" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "github_app_private_key_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.github_app_private_key.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]
@@ -117,9 +117,9 @@ resource "google_secret_manager_secret" "github_app_client_id" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "github_app_client_id_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.github_app_client_id.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]
@@ -138,9 +138,9 @@ resource "google_secret_manager_secret" "github_app_client_secret" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "github_app_client_secret_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.github_app_client_secret.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]
@@ -159,9 +159,9 @@ resource "google_secret_manager_secret" "github_bot_app_private_key" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "github_bot_app_private_key_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.github_bot_app_private_key.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]
@@ -180,9 +180,9 @@ resource "google_secret_manager_secret" "github_bot_app_client_id" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "github_bot_app_client_id_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.github_bot_app_client_id.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]
@@ -201,9 +201,9 @@ resource "google_secret_manager_secret" "github_bot_app_client_secret" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "github_bot_app_client_secret_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.github_bot_app_client_secret.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]
@@ -223,9 +223,9 @@ resource "google_secret_manager_secret" "notifications_email_user" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "notifications_email_user_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.notifications_email_user.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]
@@ -244,9 +244,9 @@ resource "google_secret_manager_secret" "notifications_email_password" {
 }
 
 resource "google_secret_manager_secret_iam_binding" "notifications_email_password_binding" {
-  project = local.project
+  project   = local.project
   secret_id = google_secret_manager_secret.notifications_email_password.secret_id
-  role = "roles/secretmanager.secretAccessor"
+  role      = "roles/secretmanager.secretAccessor"
   members = [
     "serviceAccount:${local.project}@appspot.gserviceaccount.com"
   ]