Commit 16566f3
authored
Fix variant toolchains (#1466)
In #1459,
`extra_toolchain` was changed from a string to a Label. This was
necessary (it's no longer safe to pass labels as strings in the
post-bzlmod world) but it created a problem: the ability to do
```
cmake_variant(toolchain=select({"A": "footoolchain", "B": ""}))
```
kind of worked before, and no longer does (since "" is not a valid
label). This change makes it so you can pass None instead of "" and it
will do roughly what "" did.1 parent 8e29469 commit 16566f3
1 file changed
+5
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
| |||
29 | 33 | | |
30 | 34 | | |
31 | 35 | | |
32 | | - | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
| |||
0 commit comments