Skip to content

Commit 1b198e7

Browse files
authored
fix: broken msvc builds (#1400)
1 parent f7652d7 commit 1b198e7

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

foreign_cc/private/framework.bzl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,9 @@ def _correct_path_variable(toolchain, env):
748748
# INCLUDE) needs windows path (for passing as arguments to compiler).
749749
prefix = "${EXT_BUILD_ROOT/$(printf '\072')/}/"
750750
else:
751-
prefix = "\"$EXT_BUILD_ROOT\"/"
751+
# Don't add extra quotes for shellcheck. The place where it gets used
752+
# should be quoted instead.
753+
prefix = "$EXT_BUILD_ROOT/"
752754

753755
# external/path becomes $EXT_BUILD_ROOT/external/path
754756
path_paths = [prefix + path if path and path[1] != ":" else path for path in value.split(";")]

0 commit comments

Comments
 (0)