Skip to content

Commit 625cd77

Browse files
jjmaestroJames Sharpe
andauthored
fix: full_label (#1404)
Co-authored-by: James Sharpe <[email protected]>
1 parent 336bd0f commit 625cd77

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

foreign_cc/meson.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ def meson_with_requirements(name, requirements, **kwargs):
291291
foreign_cc_rule_variant(
292292
name = name,
293293
rule = meson,
294-
toolchain = full_label("built_meson_toolchain_for_{}".format(name)),
294+
toolchain = str(full_label("built_meson_toolchain_for_{}".format(name))),
295295
**kwargs
296296
)
297297

foreign_cc/utils.bzl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,12 @@
22

33
load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
44

5-
def full_label(label):
6-
return native.repository_name() + "//" + native.package_name() + ":" + label
5+
def full_label(name):
6+
if hasattr(native, "package_relative_label"):
7+
return native.package_relative_label(name)
8+
else:
9+
# pre Bazel 6.1.0
10+
return Label(native.repository_name() + "//" + native.package_name() + ":" + name)
711

812
def runnable_binary(name, binary, foreign_cc_target, match_binary_name = False, **kwargs):
913
"""
@@ -49,11 +53,7 @@ def runnable_binary(name, binary, foreign_cc_target, match_binary_name = False,
4953
cp tmp $@
5054
"""
5155

52-
if hasattr(native, "package_relative_label"):
53-
fg_label = native.package_relative_label(name + "_fg")
54-
else:
55-
# pre Bazel 6.1.0
56-
fg_label = full_label(name + "_fg")
56+
fg_label = full_label(name + "_fg")
5757

5858
native.genrule(
5959
name = name + "_wrapper",

0 commit comments

Comments
 (0)