Skip to content

Commit d281538

Browse files
authored
Update framework.bzl to account for externalIncludes (#1215)
During our migration to Bazel 7, some of our cmake() rules broke. It turns out there is a new field in CcCompilationContext to account for external includes, as opposed to internal system_includes. See bazelbuild/bazel@a6ef0b3
1 parent c15a520 commit d281538

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

foreign_cc/private/framework.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -926,7 +926,8 @@ def get_foreign_cc_dep(dep):
926926
# consider optimization here to do not iterate both collections
927927
def _get_headers(compilation_info):
928928
include_dirs = compilation_info.system_includes.to_list() + \
929-
compilation_info.includes.to_list()
929+
compilation_info.includes.to_list() + \
930+
getattr(compilation_info, "external_includes", depset()).to_list()
930931

931932
# do not use quote includes, currently they do not contain
932933
# library-specific information

0 commit comments

Comments
 (0)