Skip to content

Commit d70efd6

Browse files
allsey87James Sharpe
andauthored
Fix _get_make_variables ignoring user environment variables (#1230)
Co-authored-by: James Sharpe <[email protected]>
1 parent 3ffc4bd commit d70efd6

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

foreign_cc/private/make_env_vars.bzl

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,14 @@ def _get_make_variables(workspace_name, tools, flags, user_env_vars, make_comman
9999
vars = {}
100100

101101
for flag in _MAKE_FLAGS:
102-
flag_value = getattr(flags, _MAKE_FLAGS[flag])
103-
if flag_value:
104-
vars[flag] = flag_value
105-
106-
# Merge flags lists
107-
for user_var in user_env_vars:
108-
toolchain_val = vars.get(user_var)
109-
if toolchain_val:
110-
vars[user_var] = toolchain_val + [user_env_vars[user_var]]
102+
toolchain_flags = getattr(flags, _MAKE_FLAGS[flag], [])
103+
user_flags = [
104+
user_flag
105+
for user_flag in user_env_vars.get(flag, "").split(" ")
106+
if user_flag
107+
]
108+
if toolchain_flags or user_flags:
109+
vars[flag] = toolchain_flags + user_flags
111110

112111
tools_dict = {}
113112
for tool in _MAKE_TOOLS:

0 commit comments

Comments
 (0)