Skip to content

Commit d9367d2

Browse files
authored
Merge user provided CPPFLAGS with build system CPPFLAGS (#1261)
1 parent 4d2cb3e commit d9367d2

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

foreign_cc/private/make_env_vars.bzl

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ def get_make_env_vars(
2626

2727
# -I flags should be put into preprocessor flags, CPPFLAGS
2828
# https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Preset-Output-Variables.html
29-
vars["CPPFLAGS"] = deps_flags.flags
29+
if "CPPFLAGS" in vars.keys():
30+
vars["CPPFLAGS"] = vars["CPPFLAGS"] + deps_flags.flags
31+
else:
32+
vars["CPPFLAGS"] = deps_flags.flags
3033

3134
return " ".join(["{}=\"{}\""
3235
.format(key, _join_flags_list(workspace_name, vars[key])) for key in vars])
@@ -108,6 +111,11 @@ def _get_make_variables(workspace_name, tools, flags, user_env_vars, make_comman
108111
if toolchain_flags or user_flags:
109112
vars[flag] = toolchain_flags + user_flags
110113

114+
# Add user defined CPPFLAGS
115+
user_cpp_flags = [flag for flag in user_env_vars.get("CPPFLAGS", "").split(" ") if flag]
116+
if user_cpp_flags:
117+
vars["CPPFLAGS"] = user_cpp_flags
118+
111119
tools_dict = {}
112120
for tool in _MAKE_TOOLS:
113121
tool_value = getattr(tools, _MAKE_TOOLS[tool])

0 commit comments

Comments
 (0)