Skip to content

Calls to rm -rf and mkdir are improperly quoted #1388

@gr1mpatr0n

Description

@gr1mpatr0n

Calls to rm -rf and mkdir, such as in rm -rf $BUILD_TMPDIR and mkdir -p $INSTALLDIR are not properly quoted and therefore do not handle paths containing spaces. I would go so far as to consider this a security issue, as the generated script may end up force-deleting any directory on a user's system for which it has permission to do so.

This issue is most apparent on Windows systems, where paths containing spaces are commonplace.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions