Add additional tests for symlinks, fix bug in symlink resolval

cmfcmf · cmfcmf · commit 4994eccf1b44 · 2025-08-01T11:18:46.000+02:00
diff --git a/go/tools/builders/go_path.go b/go/tools/builders/go_path.go
@@ -119,7 +119,7 @@ func copySymlinkRecursively(src, dst string, writeFile func(src, dst string) err
 		return err
 	}
 	if !filepath.IsAbs(target) {
-		target = filepath.Join(src, target)
+		target = filepath.Join(filepath.Dir(src), target)
 	}
 
 	return copyRecursively(target, dst, writeFile, createDir)
diff --git a/tests/core/go_path/pkg/lib/directory/a.txt b/tests/core/go_path/pkg/lib/directory/a.txt
@@ -0,0 +1 @@
+a
diff --git a/tests/core/go_path/pkg/lib/directory/nested-directory/b.txt b/tests/core/go_path/pkg/lib/directory/nested-directory/b.txt
@@ -0,0 +1 @@
+b
diff --git a/tests/core/go_path/pkg/lib/directory/nested-directory/symlink_a.txt b/tests/core/go_path/pkg/lib/directory/nested-directory/symlink_a.txt
@@ -0,0 +1 @@
+../a.txt
diff --git a/tests/core/go_path/pkg/lib/directory/nested-directory/symlink_b.txt b/tests/core/go_path/pkg/lib/directory/nested-directory/symlink_b.txt
@@ -0,0 +1 @@
+b.txt
diff --git a/tests/core/go_path/pkg/lib/directory/nested/b.txt b/tests/core/go_path/pkg/lib/directory/nested/b.txt
diff --git a/tests/core/go_path/pkg/lib/directory/symlink_nested-directory b/tests/core/go_path/pkg/lib/directory/symlink_nested-directory
@@ -0,0 +1 @@
+nested-directory

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ func copySymlinkRecursively(src, dst string, writeFile func(src, dst string) err`
`119`	`119`	`return err`
`120`	`120`	`}`
`121`	`121`	`if !filepath.IsAbs(target) {`
`122`		`- target = filepath.Join(src, target)`
	`122`	`+ target = filepath.Join(filepath.Dir(src), target)`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`return copyRecursively(target, dst, writeFile, createDir)`