Fix buildinfo generation and formatting issues

This commit addresses three test failures:
1. metadata_test - buildinfo was not being generated for binaries with only internal deps
2. external_deps_test - same issue as above
3. buildifier_test - Bazel files needed reformatting

Changes:
- importcfg.go: Generate buildinfo whenever buildinfoFile is provided, not just when deps list is non-empty. This ensures metadata is embedded even when all dependencies are internal (filtered out).
- Reformat Bazel files with buildifier to fix formatting issues (sorted load statements, added blank lines per style guide)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: jsharpe

go/BUILD.bazel

@@ -51,10 +51,10 @@ bzl_library(
         "//go/private:context",
         "//go/private:go_toolchain",
         "//go/private:providers",
+        "//go/private/aspects:all_rules",
         "//go/private/rules:library",
         "//go/private/rules:nogo",
         "//go/private/rules:sdk",
-        "//go/private/aspects:all_rules",
         "//go/private/rules:source",
         "//go/private/rules:wrappers",
         "//go/private/tools:path",

go/private/actions/link.bzl

@@ -81,6 +81,7 @@ def emit_link(
                     if hasattr(info, "module") and hasattr(info, "version"):
                         module = info.module
                         version = info.version
+
                         # Use first version (by sorted label order) if duplicates exist
                         # This makes conflicts deterministic and debuggable
                         if module not in version_map:

go/private/aspects/buildinfo_aspect.bzl

@@ -57,6 +57,7 @@ def _buildinfo_aspect_impl(target, ctx):
         attr_value = ctx.rule.attr.package_metadata
         if attr_value:
             package_metadata = attr_value if type(attr_value) == type([]) else [attr_value]
+
             # Store the metadata targets directly for later processing
             direct_metadata.extend(package_metadata)
 

go/private/rules/binary.bzl

@@ -47,16 +47,16 @@ load(
     "GoInfo",
     "GoSDK",
 )
-load(
-    "//go/private/rules:transition.bzl",
-    "go_transition",
-    "non_go_transition",
-)
 load(
     "//go/private/aspects:buildinfo_aspect.bzl",
     "BuildInfoMetadata",
     "buildinfo_aspect",
 )
+load(
+    "//go/private/rules:transition.bzl",
+    "go_transition",
+    "non_go_transition",
+)
 
 _EMPTY_DEPSET = depset([])
 

go/tools/builders/importcfg.go

@@ -219,8 +219,9 @@ package with this path is linked.`,
 		fmt.Fprintf(buf, "packagefile %s=%s\n", arc.packagePath, arc.file)
 	}
 
-	// Generate buildinfo if dependencies are provided
-	if cfg.deps != nil && len(cfg.deps) > 0 {
+	// Generate buildinfo if a buildinfo file was provided
+	// This ensures metadata is embedded even when there are no external dependencies
+	if cfg.buildinfoFile != "" {
 		buildInfo := BuildInfo{
 			GoVersion: runtime.Version(),
 			Path:      cfg.path,

tests/core/buildinfo/BUILD.bazel

@@ -4,8 +4,8 @@ load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test")
 test_suite(
     name = "buildinfo",
     tests = [
-        ":metadata_test",
         ":external_deps_test",
+        ":metadata_test",
     ],
 )