Skip to content

Commit b764503

Browse files
authored
correct macOS Tahoe 26 build via apple_support (#4500)
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** All of rules_go tests were failing on macOS Tahoe 26 due to `missing LC_UUID load command` in the clang binary built and in other tools. Many tools from Go to bazel itself have had to drop various workarounds for these kinds of linker problems in the run-up to macOS Tahoe (see bazelbuild/apple_support@44c43c715a and bazelbuild/bazel#27014) To fix this, we bump the version of build_bazel_apple_support (a.k.a. apple_support in Bazel Central Registry) to 1.24.3 in WORKSPACE. We also have to move the build_bazel_apple_support dependency above the llvm_toolchain call in order to make sure that version is actually used. It's possible we should also upgrade the llvm_toolchain to something more modern to handle some of our deps problems. The current llvm used by rules_go is 8.0.0 and is from 2019. The latest llvm version that toolchains_llvm supports in its latest release 1.5.0 is llvm 21.1.0. **Which issues(s) does this PR fix?** Fixes #4499
1 parent 30a6f8d commit b764503

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

WORKSPACE

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,14 @@ http_archive(
139139
urls = ["https://github.com/bazelbuild/buildtools/archive/refs/tags/v6.4.0.tar.gz"],
140140
)
141141

142+
# Used for both testing objc interop and building on Apple platforms. Must be
143+
# above the llvm_toolchain declaration while it's still at 8.0.0.
144+
http_archive(
145+
name = "build_bazel_apple_support",
146+
sha256 = "85a7dc13e370f355bf00381238d1cba56450d3e598566b8c52d90ddf301c5dfb",
147+
url = "https://github.com/bazelbuild/apple_support/releases/download/1.24.3/apple_support.1.24.3.tar.gz",
148+
)
149+
142150
# For manual testing against an LLVM toolchain.
143151
# Use --extra_toolchains=@llvm_toolchain//:cc-toolchain-linux,@llvm_toolchain//:cc-toolchain-darwin
144152
http_archive(
@@ -293,13 +301,6 @@ load("@io_bazel_stardoc//:setup.bzl", "stardoc_repositories")
293301

294302
stardoc_repositories()
295303

296-
# For testing objc_library interop, users should not need to install it
297-
http_archive(
298-
name = "build_bazel_apple_support",
299-
sha256 = "100d12617a84ebc7ee7a10ecf3b3e2fdadaebc167ad93a21f820a6cb60158ead",
300-
url = "https://github.com/bazelbuild/apple_support/releases/download/1.12.0/apple_support.1.12.0.tar.gz",
301-
)
302-
303304
load(
304305
"@build_bazel_apple_support//lib:repositories.bzl",
305306
"apple_support_dependencies",

0 commit comments

Comments
 (0)