Update Go SDKs (#4272)

**What type of PR is this?**

Other

**What does this PR do? Why is it needed?**

Update WORKSPACE to 1.24.0 to starting testing and bump the default SDK
with Bzlmod to 1.23.6 in line with our policy to use the latest minor
version of the oldest maintained release.


**Which issues(s) does this PR fix?**

Fixes #4267

**Other notes for review**

Author: fmeum

MODULE.bazel

@@ -18,7 +18,7 @@ bazel_dep(name = "rules_shell", version = "0.3.0")
 go_sdk = use_extension("//go:extensions.bzl", "go_sdk")
 go_sdk.download(
     name = "go_default_sdk",
-    version = "1.22.7",
+    version = "1.23.6",
 )
 use_repo(
     go_sdk,

WORKSPACE

@@ -27,11 +27,15 @@ bazel_features_deps()
 
 go_rules_dependencies()
 
-go_register_toolchains(version = "1.23.1")
+go_register_toolchains(version = "1.24.0")
+
+# Required since nogo depends on golang.org/x/tools, which needs to be at
+# least version 0.30.0 to be compatible with Go 1.24, but references
+# types.Info.FileVersions, which was only added to Go 1.22.
 
 go_download_sdk(
     name = "rules_go_internal_compatibility_sdk",
-    version = "1.19.13",
+    version = "1.22.12",
 )
 
 go_register_nogo(

go/private/repositories.bzl

@@ -65,13 +65,13 @@ def go_rules_dependencies(force = False):
     wrapper(
         http_archive,
         name = "org_golang_x_tools",
-        # v0.21.0, latest as of 2024-05-20
+        # v0.30.0, latest as of 2025-02-13
         urls = [
-            "https://mirror.bazel.build/github.com/golang/tools/archive/refs/tags/v0.21.0.zip",
-            "https://github.com/golang/tools/archive/refs/tags/v0.21.0.zip",
+            "https://mirror.bazel.build/github.com/golang/tools/archive/refs/tags/v0.30.0.zip",
+            "https://github.com/golang/tools/archive/refs/tags/v0.30.0.zip",
         ],
-        sha256 = "3e679aad1044575b90c14d13f2caa27840e46b38ac2a1dd391937300af56467a",
-        strip_prefix = "tools-0.21.0",
+        sha256 = "0736b1a0aa28f48074891a0f93cef5396575dbd73b9b5cdc4de54b2a3bfa4b4b",
+        strip_prefix = "tools-0.30.0",
         patches = [
             # deletegopls removes the gopls subdirectory. It contains a nested
             # module with additional dependencies. It's not needed by rules_go.

tests/core/compatibility/BUILD.bazel

@@ -7,6 +7,6 @@ go_binary(
 
 go_cross_binary(
     name = "hello_old",
-    sdk_version = "1.19",
+    sdk_version = "1.22",
     target = ":hello",
 )

tests/integration/popular_repos/BUILD.bazel

@@ -34,7 +34,6 @@ test_suite(
         "@org_golang_x_crypto//chacha20poly1305:chacha20poly1305_test",
         "@org_golang_x_crypto//cryptobyte:cryptobyte_test",
         "@org_golang_x_crypto//curve25519:curve25519_test",
-        "@org_golang_x_crypto//curve25519/internal/field:field_test",
         "@org_golang_x_crypto//ed25519:ed25519_test",
         "@org_golang_x_crypto//hkdf:hkdf_test",
         "@org_golang_x_crypto//internal/alias:alias_test",
@@ -176,14 +175,12 @@ test_suite(
         "@org_golang_x_tools//go/analysis/passes/internal/analysisutil:analysisutil_test",
         "@org_golang_x_tools//go/ast/astutil:astutil_test",
         "@org_golang_x_tools//go/callgraph:callgraph_test",
-        "@org_golang_x_tools//go/callgraph/static:static_test",
         "@org_golang_x_tools//go/callgraph/vta/internal/trie:trie_test",
         "@org_golang_x_tools//godoc/redirect:redirect_test",
         "@org_golang_x_tools//godoc/vfs:vfs_test",
         "@org_golang_x_tools//godoc/vfs/gatefs:gatefs_test",
         "@org_golang_x_tools//godoc/vfs/mapfs:mapfs_test",
         "@org_golang_x_tools//internal/aliases:aliases_test",
-        "@org_golang_x_tools//internal/analysisinternal:analysisinternal_test",
         "@org_golang_x_tools//internal/bisect:bisect_test",
         "@org_golang_x_tools//internal/diff:diff_test",
         "@org_golang_x_tools//internal/diff/lcs:lcs_test",
@@ -195,12 +192,14 @@ test_suite(
         "@org_golang_x_tools//internal/event/export/ocagent/wire:wire_test",
         "@org_golang_x_tools//internal/event/keys:keys_test",
         "@org_golang_x_tools//internal/event/label:label_test",
-        "@org_golang_x_tools//internal/fuzzy:fuzzy_test",
         "@org_golang_x_tools//internal/gopathwalk:gopathwalk_test",
         "@org_golang_x_tools//internal/jsonrpc2:jsonrpc2_test",
         "@org_golang_x_tools//internal/jsonrpc2/servertest:servertest_test",
         "@org_golang_x_tools//internal/jsonrpc2_v2:jsonrpc2_v2_test",
         "@org_golang_x_tools//internal/memoize:memoize_test",
+        "@org_golang_x_tools//internal/modindex:modindex_test",
+        "@org_golang_x_tools//internal/packagestest/testdata:testdata_test",
+        "@org_golang_x_tools//internal/pkgbits:pkgbits_test",
         "@org_golang_x_tools//internal/proxydir:proxydir_test",
         "@org_golang_x_tools//internal/robustio:robustio_test",
         "@org_golang_x_tools//internal/stack:stack_test",
@@ -270,13 +269,13 @@ build_test(
         "@org_golang_x_tools//cmd/file2fuzz:file2fuzz",
         "@org_golang_x_tools//cmd/fiximports:fiximports",
         "@org_golang_x_tools//cmd/gonew:gonew",
-        "@org_golang_x_tools//cmd/gorename:gorename",
         "@org_golang_x_tools//cmd/signature-fuzzer/fuzz-driver:fuzz-driver",
         "@org_golang_x_tools//cmd/signature-fuzzer/fuzz-runner:fuzz-runner",
         "@org_golang_x_tools//cmd/stringer:stringer",
         "@org_golang_x_tools//container/intsets:intsets",
         "@org_golang_x_tools//copyright:copyright",
         "@org_golang_x_tools//go/analysis/analysistest:analysistest",
+        "@org_golang_x_tools//go/analysis/checker:checker",
         "@org_golang_x_tools//go/analysis/multichecker:multichecker",
         "@org_golang_x_tools//go/analysis/passes/asmdecl:asmdecl",
         "@org_golang_x_tools//go/analysis/passes/appends:appends",
@@ -325,11 +324,13 @@ build_test(
         "@org_golang_x_tools//go/analysis/passes/unusedwrite:unusedwrite",
         "@org_golang_x_tools//go/analysis/passes/timeformat:timeformat",
         "@org_golang_x_tools//go/analysis/passes/usesgenerics:usesgenerics",
+        "@org_golang_x_tools//go/analysis/passes/waitgroup:waitgroup",
         "@org_golang_x_tools//go/analysis/unitchecker:unitchecker",
         "@org_golang_x_tools//go/ast/inspector:inspector",
         "@org_golang_x_tools//go/buildutil:buildutil",
         "@org_golang_x_tools//go/callgraph/cha:cha",
         "@org_golang_x_tools//go/callgraph/rta:rta",
+        "@org_golang_x_tools//go/callgraph/static:static",
         "@org_golang_x_tools//go/callgraph/vta:vta",
         "@org_golang_x_tools//go/cfg:cfg",
         "@org_golang_x_tools//go/expect:expect",

tests/integration/popular_repos/README.rst

@@ -26,7 +26,6 @@ This runs tests from the repository `golang.org/x/crypto <https://golang.org/x/c
 * @org_golang_x_crypto//chacha20poly1305:chacha20poly1305_test
 * @org_golang_x_crypto//cryptobyte:cryptobyte_test
 * @org_golang_x_crypto//curve25519:curve25519_test
-* @org_golang_x_crypto//curve25519/internal/field:field_test
 * @org_golang_x_crypto//ed25519:ed25519_test
 * @org_golang_x_crypto//hkdf:hkdf_test
 * @org_golang_x_crypto//internal/alias:alias_test
@@ -172,14 +171,12 @@ This runs tests from the repository `golang.org/x/tools <https://golang.org/x/to
 * @org_golang_x_tools//go/analysis/passes/internal/analysisutil:analysisutil_test
 * @org_golang_x_tools//go/ast/astutil:astutil_test
 * @org_golang_x_tools//go/callgraph:callgraph_test
-* @org_golang_x_tools//go/callgraph/static:static_test
 * @org_golang_x_tools//go/callgraph/vta/internal/trie:trie_test
 * @org_golang_x_tools//godoc/redirect:redirect_test
 * @org_golang_x_tools//godoc/vfs:vfs_test
 * @org_golang_x_tools//godoc/vfs/gatefs:gatefs_test
 * @org_golang_x_tools//godoc/vfs/mapfs:mapfs_test
 * @org_golang_x_tools//internal/aliases:aliases_test
-* @org_golang_x_tools//internal/analysisinternal:analysisinternal_test
 * @org_golang_x_tools//internal/bisect:bisect_test
 * @org_golang_x_tools//internal/diff:diff_test
 * @org_golang_x_tools//internal/diff/lcs:lcs_test
@@ -191,12 +188,14 @@ This runs tests from the repository `golang.org/x/tools <https://golang.org/x/to
 * @org_golang_x_tools//internal/event/export/ocagent/wire:wire_test
 * @org_golang_x_tools//internal/event/keys:keys_test
 * @org_golang_x_tools//internal/event/label:label_test
-* @org_golang_x_tools//internal/fuzzy:fuzzy_test
 * @org_golang_x_tools//internal/gopathwalk:gopathwalk_test
 * @org_golang_x_tools//internal/jsonrpc2:jsonrpc2_test
 * @org_golang_x_tools//internal/jsonrpc2/servertest:servertest_test
 * @org_golang_x_tools//internal/jsonrpc2_v2:jsonrpc2_v2_test
 * @org_golang_x_tools//internal/memoize:memoize_test
+* @org_golang_x_tools//internal/modindex:modindex_test
+* @org_golang_x_tools//internal/packagestest/testdata:testdata_test
+* @org_golang_x_tools//internal/pkgbits:pkgbits_test
 * @org_golang_x_tools//internal/proxydir:proxydir_test
 * @org_golang_x_tools//internal/robustio:robustio_test
 * @org_golang_x_tools//internal/stack:stack_test

tests/integration/popular_repos/popular_repos.bzl

@@ -27,7 +27,7 @@ def popular_repos():
         go_repository,
         name = "org_golang_x_crypto",
         importpath = "golang.org/x/crypto",
-        commit = "0d375be9b61cb69eb94173d0375a05e90875bbf6",
+        commit = "e47973b1c1089f6c67ab89261f7aa067b3d611d2",
     )
     _maybe(
         go_repository,

tests/integration/popular_repos/popular_repos.py

@@ -13,15 +13,14 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from subprocess import check_output, call
-from sys import exit
 from os import path
+from subprocess import check_output
 
 POPULAR_REPOS = [
     dict(
         name = "org_golang_x_crypto",
         importpath = "golang.org/x/crypto",
-        commit = "0d375be9b61cb69eb94173d0375a05e90875bbf6",
+        commit = "e47973b1c1089f6c67ab89261f7aa067b3d611d2",
         excludes = [
             "internal/wycheproof:wycheproof_test", # requires build cache
             "nacl/secretbox:secretbox_test", # panics in salsa2020_amd64.s
@@ -89,7 +88,6 @@
             "cmd/deadcode:deadcode_test", # Needs GOROOT
             "cmd/godoc:godoc_test", # TODO(#417)
             "cmd/gonew:gonew_test", # requires build cache
-            "cmd/gorename:gorename_test", # TODO(#417)
             "cmd/guru/testdata/src/referrers:referrers_test", # Not a real test
             # "cmd/guru:guru_test", # Needs testdata directory
             "cmd/signature-fuzzer/fuzz-driver:fuzz-driver_test", # requires working GOROOT
@@ -99,6 +97,7 @@
             "container/intsets:intsets_test", # TODO(#413): External test depends on symbols defined in internal test.
             "copyright:copyright_test", # # requires runfiles
             "go/analysis/analysistest:analysistest_test", # requires build cache
+            "go/analysis/checker:checker_test", # Needs go tool
             "go/analysis/internal/analysisflags:analysisflags_test", # calls os.Exit(0) in a test
             "go/analysis/internal/checker:checker_test", # loads test package with go/packages, which probably needs go list
             "go/analysis/internal/versiontest:versiontest_test", # Needs GOROOT
@@ -155,11 +154,13 @@
             "go/analysis/passes/unusedwrite:unusedwrite_test", # Needs testdata directory
             "go/analysis/passes/timeformat:timeformat_test", # Needs go tool
             "go/analysis/passes/usesgenerics:usesgenerics_test", # Needs go tool
+            "go/analysis/passes/waitgroup:waitgroup_test", # Needs go tool
             "go/analysis/unitchecker:unitchecker_test", # requires go vet
             "go/ast/inspector:inspector_test", # requires GOROOT and GOPATH
             "go/buildutil:buildutil_test", # Needs testdata directory
             "go/callgraph/cha:cha_test", # Needs testdata directory
             "go/callgraph/rta:rta_test", # Needs testdata directory
+            "go/callgraph/static:static_test", # Needs go tool
             "go/callgraph/vta:vta_test", # Needs testdata directory
             "go/cfg:cfg_test", # Needs GOROOT
             "go/expect:expect_test", # Needs testdata directory
@@ -180,13 +181,19 @@
             "godoc/static:static_test", # requires data files
             "godoc/vfs/zipfs:zipfs_test", # requires GOROOT
             "godoc:godoc_test", # requires GOROOT and GOPATH
+            "internal/analysisinternal:analysisinternal_test", # requires GOROOT and GOPATH
             "internal/apidiff:apidiff_test", # Needs testdata directory
+            "internal/astutil/cursor:cursor_test", # requires GOROOT
             "internal/diff/difftest:difftest_test", # Needs diff tool
             "internal/diffp:diffp_test", # Needs testdata directory
+            "internal/drivertest:drivertest_test", # Needs go tool
+            "internal/expect:expect_test", # Needs testdata directory
             "internal/facts:facts_test", # loads test package with go/packages, which probably needs go list
             "internal/gcimporter:gcimporter_test", # Needs testdata directory
             "internal/gocommand:gocommand_test", # Needs go tool
             "internal/imports:imports_test", # Needs testdata directory
+            "internal/packagestest:packagestest_test", # Needs go tool
+            "internal/packagestest/testdata/groups/two/primarymod/expect:expect_test",
             "internal/pprof:pprof_test", # Needs testdata directory
             "internal/refactor/inline:inline_test", # Needs GOROOT
             "internal/refactor/inline/analyzer:analyzer_test", # Needs GOROOT