Stop using incompatible_use_toolchain_transition

EdSchouten · jbedard · commit 1fc6b6b763c4 · 2025-01-16T10:56:48.000-08:00
As documented at https://bazel.build/rules/lib/globals/bzl.html#rule: incompatible_use_toolchain_transition bool; default is False Deprecated, this is no longer in use and should be removed. According to bazelbuild/bazel#14049, this feature was enabled by default back in 2021.
diff --git a/nodejs/private/nodejs_toolchains_repo.bzl b/nodejs/private/nodejs_toolchains_repo.bzl
@@ -83,7 +83,6 @@ def _resolved_toolchain_impl(ctx):
 resolved_toolchain = rule(
     implementation = _resolved_toolchain_impl,
     toolchains = ["@rules_nodejs//nodejs:toolchain_type"],
-    incompatible_use_toolchain_transition = True,
 )
 """
     repository_ctx.file("defs.bzl", starlark_content)

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ def _resolved_toolchain_impl(ctx):`
`83`	`83`	`resolved_toolchain = rule(`
`84`	`84`	`implementation = _resolved_toolchain_impl,`
`85`	`85`	`toolchains = ["@rules_nodejs//nodejs:toolchain_type"],`
`86`		`- incompatible_use_toolchain_transition = True,`
`87`	`86`	`)`
`88`	`87`	`"""`
`89`	`88`	`repository_ctx.file("defs.bzl", starlark_content)`