Skip to content

Commit 343bc48

Browse files
fix: add missing windows arm64 in os_arch_names (#3856)
A previous commit added support for Windows arm64, but I forgot to add it to OS_ARCH_NAMES, so it's not _actually_ working yet. This commit adds it. Ref: 12d90ec
1 parent 7b57c07 commit 343bc48

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

nodejs/private/os_name.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ load(":node_versions.bzl", "NODE_VERSIONS")
1919

2020
OS_ARCH_NAMES = [
2121
("windows", "amd64"),
22+
("windows", "arm64"),
2223
("darwin", "amd64"),
2324
("darwin", "arm64"),
2425
("linux", "amd64"),
@@ -78,4 +79,4 @@ def assert_node_exists_for_host(rctx):
7879
if not node_exists_for_os(node_version, os_name(rctx), node_repositories):
7980
fail("No nodejs is available for {} at version {}".format(os_name(rctx), node_version) +
8081
"\n Consider upgrading by setting node_version in a call to node_repositories in WORKSPACE." +
81-
"\n Note that Node 16.x is the minimum published for Apple Silicon (M1 Macs)")
82+
"\n Note that Node 16.x is the minimum published for Apple Silicon (M1 Macs), and 20.x is the minimum for Windows ARM64.")

0 commit comments

Comments
 (0)