test: node v24+ toolchains

Author: jbedard

.bazelci/presubmit.yml

@@ -91,5 +91,7 @@ tasks:
     working_directory: "e2e/smoke"
     build_targets:
       - "//..."
+    test_flags:
+      - "--test_tag_filters=-skip-on-bazelci-ubuntu"
     test_targets:
       - "//..."

e2e/smoke/BUILD.bazel

@@ -234,6 +234,12 @@ write_file(
     content = ["v16.5.0"],
 )
 
+write_file(
+    name = "write_node_version_24",
+    out = "expected_node_24",
+    content = ["v24.12.0"],
+)
+
 # To see what nodejs version is used by default
 my_nodejs(
     name = "run_no_toolchain",
@@ -312,3 +318,24 @@ diff_test(
     file1 = "write_node_version_15",
     file2 = "thing_toolchain_15",
 )
+
+my_nodejs(
+    name = "run_24",
+    out = "thing_toolchain_24",
+    entry_point = "version.js",
+    # using the select statement will download toolchains for all three platforms
+    # you can also just provide an individual toolchain if you don't want to download them all
+    toolchain = select({
+        "@bazel_tools//src/conditions:linux_x86_64": "@node24_linux_amd64//:toolchain",
+        "@bazel_tools//src/conditions:linux_aarch64": "@node24_linux_arm64//:toolchain",
+        "@bazel_tools//src/conditions:darwin_x86_64": "@node24_darwin_amd64//:toolchain",
+        "@bazel_tools//src/conditions:darwin_arm64": "@node24_darwin_arm64//:toolchain",
+        "@bazel_tools//src/conditions:windows": "@node24_windows_amd64//:toolchain",
+    }),
+)
+
+diff_test(
+    name = "test_node_version_24",
+    file1 = "write_node_version_24",
+    file2 = "thing_toolchain_24",
+)

e2e/smoke/MODULE.bazel

@@ -23,6 +23,12 @@ node.toolchain(
     node_version = "15.14.0",
 )
 
+# Node24 changed some directory structures: https://github.com/bazel-contrib/rules_nodejs/issues/3887
+node.toolchain(
+    name = "node24",
+    node_version = "24.12.0",
+)
+
 # FIXME(6.0): a repo rule with name=foo should create a repo named @foo, not @foo_toolchains
 use_repo(
     node,
@@ -34,6 +40,11 @@ use_repo(
     "node17_linux_amd64",
     "node17_linux_arm64",
     "node17_windows_amd64",
+    "node24_darwin_amd64",
+    "node24_darwin_arm64",
+    "node24_linux_amd64",
+    "node24_linux_arm64",
+    "node24_windows_amd64",
     "nodejs_darwin_amd64",
     "nodejs_darwin_arm64",
     "nodejs_linux_amd64",

e2e/smoke/WORKSPACE.bazel

@@ -25,6 +25,11 @@ nodejs_register_toolchains(
     node_version = "15.14.0",
 )
 
+nodejs_register_toolchains(
+    name = "node24",
+    node_version = "24.12.0",
+)
+
 http_archive(
     name = "npm_acorn-8.5.0",
     build_file_content = """load("@bazel_lib//lib:copy_directory.bzl", "copy_directory")