chore: stop skipping some tests on bazelci

Author: jbedard

.bazelci/presubmit.yml

@@ -12,8 +12,6 @@ tasks:
     platform: ubuntu1804
     build_targets:
       - "//..."
-    test_flags:
-      - "--test_tag_filters=-skip-on-bazelci-ubuntu"
     test_targets:
       - "//..."
   ubuntu1804-headers:
@@ -22,8 +20,6 @@ tasks:
     working_directory: "e2e/headers"
     build_targets:
       - "//..."
-    test_flags:
-      - "--test_tag_filters=-skip-on-bazelci-ubuntu"
     test_targets:
       - "//..."
   ubuntu1804-smoke:
@@ -32,8 +28,6 @@ tasks:
     working_directory: "e2e/smoke"
     build_targets:
       - "//..."
-    test_flags:
-      - "--test_tag_filters=-skip-on-bazelci-ubuntu"
     test_targets:
       - "//..."
   ubuntu1804-nodejs_host:
@@ -42,8 +36,6 @@ tasks:
     working_directory: "e2e/nodejs_host"
     build_targets:
       - "//..."
-    test_flags:
-      - "--test_tag_filters=-skip-on-bazelci-ubuntu"
     test_targets:
       - "//..."
   macos:
@@ -91,17 +83,13 @@ tasks:
     working_directory: "e2e/nodejs_host"
     build_targets:
       - "//..."
-    test_flags:
-      - "--test_tag_filters=-skip-on-bazelci-windows"
     test_targets:
       - "//..."
-  rbe_ubuntu1604-smoke:
-    name: rbe_ubuntu1604-smoke
-    platform: rbe_ubuntu1604
+  rbe_ubuntu1804-smoke:
+    name: rbe_ubuntu1804-smoke
+    platform: rbe_ubuntu1804
     working_directory: "e2e/smoke"
     build_targets:
       - "//..."
-    test_flags:
-      - "--test_tag_filters=-skip-on-bazelci-ubuntu"
     test_targets:
       - "//..."

e2e/nodejs_host/BUILD.bazel

@@ -48,24 +48,21 @@
             "@%s//:node" % node_toolchain,
             "@bazel_tools//tools/bash/runfiles",
         ],
-        tags = tags,
     )
-    for (node_toolchain, tool, tags) in [
+    for (node_toolchain, tool) in [
         (
             "nodejs",
             "npm",
-            ["skip-on-bazelci-ubuntu"],  # fails on Bazel CI Ubuntu on latest Node.js due to GLIBC version on runner: "GLIBC_2.28 not found" (https://buildkite.com/bazel/rules-nodejs-nodejs/builds/13451#018feffd-4878-46e4-8582-ae94648a2d74)
         ),
         (
             "nodejs",
             "npx",
-            ["skip-on-bazelci-ubuntu"],  # fails on Bazel CI Ubuntu on latest Node.js due to GLIBC version on runner: "GLIBC_2.28 not found" (https://buildkite.com/bazel/rules-nodejs-nodejs/builds/13451#018feffd-4878-46e4-8582-ae94648a2d74)
         ),
-        ("node16", "npm", []),
-        ("node16", "npx", []),
-        ("node16_nvmrc", "npm", []),
-        ("node16_nvmrc", "npx", []),
-        ("node17_custom", "npm", []),
-        ("node17_custom", "npx", []),
+        ("node16", "npm"),
+        ("node16", "npx"),
+        ("node16_nvmrc", "npm"),
+        ("node16_nvmrc", "npx"),
+        ("node17_custom", "npm"),
+        ("node17_custom", "npx"),
     ]
 ]

e2e/smoke/BUILD.bazel

@@ -323,7 +323,6 @@ my_nodejs(
     name = "run_24",
     out = "thing_toolchain_24",
     entry_point = "version.js",
-    tags = ["skip-on-bazelci-ubuntu"],  # fails on Bazel CI Ubuntu on latest Node.js due to GLIBC version on runner: "GLIBC_2.28 not found" (https://buildkite.com/bazel/rules-nodejs-nodejs/builds/14235#019b4856-6461-4f2d-b6f9-d7d722fcac99)
     # using the select statement will download toolchains for all three platforms
     # you can also just provide an individual toolchain if you don't want to download them all
     toolchain = select({
@@ -339,5 +338,4 @@ diff_test(
     name = "test_node_version_24",
     file1 = "write_node_version_24",
     file2 = "thing_toolchain_24",
-    tags = ["skip-on-bazelci-ubuntu"],  # fails on Bazel CI Ubuntu on latest Node.js due to GLIBC version on runner: "GLIBC_2.28 not found" (https://buildkite.com/bazel/rules-nodejs-nodejs/builds/14235#019b4856-6461-4f2d-b6f9-d7d722fcac99)
 )