Skip to content

Commit f12af86

Browse files
committed
Introduce runtime_toolchain_type
According to discussions in #3854 having two toolchains of the same type for different things is troublesome. It's better to have separate runtime as well as compile toolchains. This commit creates a new runtime_toolchain_type and registers toolchains without execution constraints for this type. Once merged, rules_ts can start consuming the new toolchain type in its js_binary rule to ensure the correct Node for the correct target environment is selected. Fixed [Bug]: Execution toolchain defined without `target_compatible_with` makes it a candidate to selection Fixes #3854 Work towards #3795
1 parent 708d1ec commit f12af86

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

nodejs/node_toolchain_alias.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ node_host_runtime_alias = rule(
5353
implementation = _node_host_runtime_alias,
5454
attrs = {
5555
"_runtime": attr.label(
56-
default = Label("//toolchains:current_node_runtime"),
56+
default = Label("//nodejs:current_node_runtime"),
5757
providers = [
5858
NodeInfo,
5959
platform_common.TemplateVariableInfo,

0 commit comments

Comments
 (0)