[Bug]: rules_nodejs breaks with Node.js 24.12.0

[alan-agius4]

What happened?

rules_nodejs is no compatible with Node.js version 24.12.0

ERROR: Traceback (most recent call last):
        File "/xxxx/d43f8d31ece3ad743d4ef7464bdac2b6/external/rules_nodejs++node+nodejs_linux_amd64/BUILD.bazel", line 20, column 14, in <toplevel>
                srcs = glob(["bin/nodejs/**"]) + [":node_files"],
Error in glob: glob pattern 'bin/nodejs/**' didn't match anything, but allow_empty is set to False (the default value of allow_empty can be set with --incompatible_disallow_empty_glob).
ERROR: /xxxx/d43f8d31ece3ad743d4ef7464bdac2b6/external/rules_nodejs++node+nodejs_linux_amd64/BUILD.bazel: no such target '@@rules_nodejs++node+nodejs_linux_amd64//:toolchain': target 'toolchain' not declared in package '' defined by /xxxx/d43f8d31ece3ad743d4ef7464bdac2b6/external/rules_nodejs++node+nodejs_linux_amd64/BUILD.bazel
ERROR: /xxxx/d43f8d31ece3ad743d4ef7464bdac2b6/external/rules_angular+/src/ng_package/text_replace/BUILD.bazel:23:10: Target '@@rules_angular+//src/ng_package/text_replace:bin' depends on toolchain '@@rules_nodejs++node+nodejs_linux_amd64//:toolchain', which cannot be found: no such target '@@rules_nodejs++node+nodejs_linux_amd64//:toolchain': target 'toolchain' not declared in package '' defined by /xxxx/d43f8d31ece3ad743d4ef7464bdac2b6/external/rules_nodejs++node+nodejs_linux_amd64/BUILD.bazel'
ERROR: Analysis of target '//ng-dev:npm_package' failed; build aborted: Analysis failed
INFO: Elapsed time: 0.746s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully

Version

Development (host) and target OS/architectures:

linux x64

Output of bazel --version:

bazel 8.5.0

bazel_dep(name = "rules_nodejs", version = "6.6.2")

node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
node.toolchain(node_version = "24.12.0")
use_repo(node, "nodejs_toolchains")

Additional Information

Using --incompatible_disallow_empty_glob=false is not enough as eventually it will lead to missing input files errors example:

INFO: Analyzed target //ng-dev:npm_package (664 packages loaded, 3756 targets configured).
ERROR: /xxxxx/d43f8d31ece3ad743d4ef7464bdac2b6/external/aspect_rules_esbuild++esbuild+esbuild_linux-x64/BUILD.bazel:11:10: Middleman _middlemen/external_Saspect_Urules_Uesbuild++esbuild+esbuild_Ulinux-x64_Slauncher_U_Slauncher-runfiles failed: missing input file '@@rules_nodejs++node+nodejs_linux_amd64//:bin/nodejs/bin/node'
ERROR: /xxxxx/d43f8d31ece3ad743d4ef7464bdac2b6/external/aspect_rules_esbuild++esbuild+esbuild_linux-x64/BUILD.bazel:11:10: Middleman _middlemen/external_Saspect_Urules_Uesbuild++esbuild+esbuild_Ulinux-x64_Slauncher_U_Slauncher-runfiles failed: 1 input file(s) do not exist
Target //ng-dev:npm_package failed to build
Use --verbose_failures to see the command lines of failed build steps.
ERROR: /xxxxx/d43f8d31ece3ad743d4ef7464bdac2b6/external/aspect_rules_esbuild++esbuild+esbuild_linux-x64/BUILD.bazel:11:10 Middleman _middlemen/external_Saspect_Urules_Uesbuild++esbuild+esbuild_Ulinux-x64_Slauncher_U_Slauncher-runfiles failed: 1 input file(s) do not exist
INFO: Elapsed time: 10.587s, Critical Path: 0.05s
INFO: 1 process: 1868 action cache hit, 1 internal.
ERROR: Build did NOT complete successfully
 ELIFECYCLE  Command failed with exit code 1.

[alexeagle]

Thanks @alan-agius4 - do you know if nodejs changed the directory layout of their distributions?

[alan-agius4]

@alexeagle, I didn’t check to be honest, but that’s what I suspect.

[jbedard]

@alan-agius4 can you double check there aren't other errors with the download? The tar file structure seems the same to me and tests are working fine locally and most CI for me.

However my tests did fail on some CI with older glibc versions:

external/rules_nodejs~~node~node24_linux_amd64/bin/nodejs/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by external/rules_nodejs~~node~node24_linux_amd64/bin/nodejs/bin/node)

[alan-agius4]

No other errors, before that.

PR: angular/dev-infra#3343

Logs: https://productionresultssa3.blob.core.windows.net/actions-results/4e151f3f-fa19-4f11-91ec-0473fa225fa7/workflow-job-run-6a52e4d9-1a47-5fc2-9d17-c38827c1ce37/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-12-22T22%3A36%3A39Z&sig=T8DGhxZw%2BgD7hs2DorzOeuBezuIUIaDAMlEuSFfY8FQ%3D&ske=2025-12-23T10%3A00%3A42Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-12-22T22%3A00%3A42Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2025-12-22T22%3A26%3A34Z&sv=2025-11-05

[alan-agius4]

@jbedard in https://github.com/bazel-contrib/rules_nodejs/pull/3888/changes I noticed that you are using Node.js 24.11.1, the mention problem started from 24.12.0 though.

[jbedard]

I was using 24.12.0 but ran into GLIBC errors so (temporarily) downgraded just to test things out. But browsing the node releases I don't see any changes to the directory structure in 24.12.

The glibc error is one reason I ask if you had other errors.

Your Logs link is a 403 for me...

[alan-agius4]

No errors prior to the below, happens both locally and RBE. (Both Linux)

Analyzing: 572 targets (187 packages loaded, 477 targets configured)
[22 / 22] no actions running
Analyzing: 572 targets (206 packages loaded, 1561 targets configured)
[23 / 23] no actions running
ERROR: Traceback (most recent call last):
	File "/home/runner/.cache/bazel/_bazel_runner/48e0b44e0189c0be191a57f5927353cf/external/rules_nodejs++node+nodejs_linux_amd64/BUILD.bazel", line 20, column 14, in <toplevel>
		srcs = glob(["bin/nodejs/**"]) + [":node_files"],
Error in glob: glob pattern 'bin/nodejs/**' didn't match anything, but allow_empty is set to False (the default value of allow_empty can be set with --incompatible_disallow_empty_glob).
ERROR: /home/runner/.cache/bazel/_bazel_runner/48e0b44e0189c0be191a57f5927353cf/external/rules_nodejs++node+nodejs_linux_amd64/BUILD.bazel: no such target '@@rules_nodejs++node+nodejs_linux_amd64//:toolchain': target 'toolchain' not declared in package '' defined by /home/runner/.cache/bazel/_bazel_runner/48e0b44e0189c0be191a57f5927353cf/external/rules_nodejs++node+nodejs_linux_amd64/BUILD.bazel
ERROR: /home/runner/.cache/bazel/_bazel_runner/48e0b44e0189c0be191a57f5927353cf/external/rules_angular+/src/ng_package/text_replace/BUILD.bazel:23:10: Target '@@rules_angular+//src/ng_package/text_replace:bin' depends on toolchain '@@rules_nodejs++node+nodejs_linux_amd64//:toolchain', which cannot be found: no such target '@@rules_nodejs++node+nodejs_linux_amd64//:toolchain': target 'toolchain' not declared in package '' defined by /home/runner/.cache/bazel/_bazel_runner/48e0b44e0189c0be191a57f5927353cf/external/rules_nodejs++node+nodejs_linux_amd64/BUILD.bazel'
ERROR: Analysis of target '//ng-dev:npm_package_substituted' failed; build aborted: Analysis failed
INFO: Elapsed time: 21.161s, Critical Path: 0.11s
INFO: 23 processes: 23 internal.
ERROR: Build did NOT complete successfully
FAILED: 
ERROR: No test targets were found, yet testing was requested
INFO: Streaming build results to: https://source.cloud.google.com/results/invocations/d32c18ad-65b8-4390-80cf-41c0314ced96

Error: Process completed with exit code 1.

[jbedard]

Is there any way you can inspect the directory being globbed? I don't understand what's going on since that directory seems to exist and I have green tests with 24.12 now... 716bc18

[alan-agius4]

I am currently OOO, I can take a look at this on the 5th.