Skip to content

Commit 00dd72d

Browse files
aignasrickeylev
andauthored
fix: use a consistent buildifier version for CI and pre-commit (#1151)
The CI may be broken because it is using the latest version of buildifier (`6.1.0`) and the pre-commit hooks are using `6.0.0`. `6.1.0` added extra sorting, so it is now not enough to just run `pre-commit run -a buildifier` to fix the errors. I have submitted a PR to update the pre-commit hooks in keith/pre-commit-buildifier#14 and until it is merged and a new version is tagged we should use an older version of the buildifier to ensure the build is green. --------- Co-authored-by: Richard Levasseur <[email protected]>
1 parent 03ebeb7 commit 00dd72d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.bazelci/presubmit.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414

1515
---
1616
buildifier:
17-
version: latest
18-
# keep this argument in sync with .pre-commit-config.yaml
17+
# keep these arguments in sync with .pre-commit-config.yaml
18+
# Use a specific version to avoid skew issues when new versions are released.
19+
version: 6.0.0
1920
warnings: "all"
2021
.minimum_supported_version: &minimum_supported_version
2122
# For testing minimum supported version.

0 commit comments

Comments
 (0)