Commit 02ace45
authored
fix: allow url fragments in requirements file (#1195)
This commit addresses issue #1194 (see issue for details).
It brings the `comment` detection of `requirements_parser.bzl` closer to
the spec described here:
-
https://pip.pypa.io/en/stable/reference/requirements-file-format/#comments
1. Lines that begin with `#` are comments.
2. Content after (and including) ` #` is a comment.
Prior to this commit, a dependency like this would result in invalid
`pip wheel` arguments:
```
requests @ https://github.com/psf/requests/releases/download/v2.29.0/requests-2.29.0.tar.gz#sha1=3897c249b51a1a405d615a8c9cb92e5fdbf0dd49
```1 parent 07e6856 commit 02ace45
File tree
2 files changed
+10
-2
lines changed- python/pip_install
- private/test
2 files changed
+10
-2
lines changedLines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
65 | 68 | | |
66 | 69 | | |
67 | 70 | | |
| |||
71 | 74 | | |
72 | 75 | | |
73 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
74 | 82 | | |
75 | 83 | | |
76 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
| 130 | + | |
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
0 commit comments