Skip to content

Commit 07e8bc9

Browse files
committed
fix: add target platform to extra exec platforms in analysis tests
This is required as of bazelbuild/bazel@2780393 as tests now require an execution platform that matches their target constraints by default.
1 parent a4b946b commit 07e8bc9

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

tests/base_rules/py_executable_base_tests.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ def _test_basic_windows(name, config):
5353
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
5454
"//command_line_option:extra_toolchains": [CC_TOOLCHAIN],
5555
"//command_line_option:platforms": [WINDOWS_X86_64],
56+
"//command_line_option:extra_execution_platforms": [WINDOWS_X86_64],
5657
},
5758
attr_values = {"target_compatible_with": target_compatible_with},
5859
)
@@ -98,6 +99,7 @@ def _test_basic_zip(name, config):
9899
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
99100
"//command_line_option:extra_toolchains": [CC_TOOLCHAIN],
100101
"//command_line_option:platforms": [LINUX_X86_64],
102+
"//command_line_option:extra_execution_platforms": [LINUX_X86_64],
101103
},
102104
attr_values = {"target_compatible_with": target_compatible_with},
103105
)

tests/base_rules/py_test/py_test_tests.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ def _test_mac_requires_darwin_for_execution(name, config):
6161
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
6262
"//command_line_option:extra_toolchains": CC_TOOLCHAIN,
6363
"//command_line_option:platforms": [MAC_X86_64],
64+
"//command_line_option:extra_execution_platforms": [MAC_X86_64],
6465
},
6566
attr_values = _SKIP_WINDOWS,
6667
)
@@ -94,6 +95,7 @@ def _test_non_mac_doesnt_require_darwin_for_execution(name, config):
9495
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
9596
"//command_line_option:extra_toolchains": CC_TOOLCHAIN,
9697
"//command_line_option:platforms": [LINUX_X86_64],
98+
"//command_line_option:extra_execution_platforms": [LINUX_X86_64],
9799
},
98100
attr_values = _SKIP_WINDOWS,
99101
)

0 commit comments

Comments
 (0)