Skip to content

Commit 0aa16ef

Browse files
committed
Merge branch 'bump-toolchains' into check-script-default
2 parents ca3c606 + 5592571 commit 0aa16ef

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

tests/toolchains/python_toolchain_test.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,14 @@ def test_expected_toolchain_matches(self):
2727
)
2828
self.assertIn(expected, settings["toolchain_label"], msg)
2929

30-
if sys.version_info.releaselevel == "final":
31-
actual = "{v.major}.{v.minor}.{v.micro}".format(v=sys.version_info)
32-
elif sys.version_info.releaselevel in ["beta"]:
33-
actual = (
34-
"{v.major}.{v.minor}.{v.micro}{v.releaselevel[0]}{v.serial}".format(
35-
v=sys.version_info
36-
)
37-
)
38-
else:
39-
raise NotImplementedError(
40-
"Unsupported release level, please update the test"
30+
actual = "{v.major}.{v.minor}.{v.micro}".format(v=sys.version_info)
31+
if sys.version_info.releaselevel != "final":
32+
release_prefix = (
33+
"rc"
34+
if sys.version_info.releaselevel == "candidate"
35+
else sys.version_info.releaselevel[0]
4136
)
37+
actual = f"{actual}{release_prefix}{sys.version_info.serial}"
4238
self.assertEqual(actual, expect_version)
4339

4440

tests/toolchains/transitions/transitions_tests.bzl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,12 @@ def _impl(ctx):
6767
got_version.releaselevel[0],
6868
got_version.serial,
6969
)
70+
if got_version.releaselevel != "final":
71+
got = "{}{}{}".format(
72+
got,
73+
"rc" if got_version.releaselevel == "candidate" else got_version.releaselevel[0],
74+
got_version.serial,
75+
)
7076

7177
return [
7278
TestInfo(

0 commit comments

Comments
 (0)