Skip to content

Commit 0e97798

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 0b99b03 commit 0e97798

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

docs/howto/multi-platform-pypi-deps.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ arbitrary name with a list of Bazel {obj}`config_setting` targets. Any name can
3535
be used for a platform (it's name has no inherent semantic meaning), however,
3636
the name should encode all the relevant dimensions that distinguish a
3737
requirements file. For example, if a requirements file is specifically for the
38-
combination of CUDA 12.9 and NumPY 2.0, then platform name should represent
38+
combination of CUDA 12.9 and NumPy 2.0, then platform name should represent
3939
that.
4040

4141
The convention is to follow the format of `{os}_{cpu}{threading}`, where:
@@ -89,15 +89,15 @@ contains commonly used settings for OS and CPU:
8989
Note that these are the raw flag names. In order to use them with `pip.default`,
9090
you must use {obj}`config_setting()` to match a particular value for them.
9191

92-
### Associating requirements to plaforms
92+
### Associating requirements to platforms
9393

9494
Next, we associate a requirements file with a platform using
9595
{obj}`pip.parse.requirements_by_platform`. This is a dictionary arg where
9696
keys are requirements files, and the value is a platform name. The platform
9797
value can use trailing or leading `*` to match multiple platforms. It can also
9898
specify multiple platform names using commas to separate them.
9999

100-
Note that Python version is _not_ part
100+
Note that Python version is _not_ part of the platform name.
101101

102102
Under the hood, `pip.parse` merges all the requirements (for a `hub_name`) and
103103
constructs `select()` expressions to route to the appropriate dependencies.
@@ -116,15 +116,15 @@ bazel build --@rules_python//python/config_settings:py_linux_libc=musl \
116116
--cpu=aarch64 //:binary
117117

118118
# Build for freethreaded
119-
bazel build --@rule_python//python/config_settings:py_freethreaded=yes //:binary
119+
bazel build --@rules_python//python/config_settings:py_freethreaded=yes //:binary
120120
```
121121

122122
Note that certain combinations of flags may result in an error or undefined
123123
behavior. For example, trying to set both freethreaded and CUDA at the same
124124
time would result in an error because no requirements file was registered
125125
to match that combination.
126126

127-
## Multiple Python version
127+
## Multiple Python versions
128128

129129
Having multiple Python versions is fully supported. Simply add a `pip.parse()`
130130
call and set `python_version` appropriately.

0 commit comments

Comments
 (0)