Skip to content

Commit 134fa8f

Browse files
committed
use the starlark impl of marker eval
1 parent 013664d commit 134fa8f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

python/private/pypi/evaluate_markers.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ def evaluate_markers(*, requirements, platforms):
4242
for req_string, platform_strings in requirements.items():
4343
req = requirement(req_string)
4444
for platform_str in platform_strings:
45-
platform = platforms.get(platform_str)
46-
if not platform:
45+
env = platforms.get(platform_str)
46+
if not env:
4747
fail("Please define platform: '{}'".format(platform_str))
4848

49-
if evaluate(req.marker, env = platform.env):
50-
ret.setdefault(req_string, []).append(platform)
49+
if evaluate(req.marker, env = env):
50+
ret.setdefault(req_string, []).append(platform_str)
5151

5252
return ret
5353

python/private/pypi/extension.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -769,7 +769,7 @@ def _pip_impl(module_ctx):
769769
# NOTE @aignas 2025-04-15: this is set to be reproducible, because the
770770
# results after calling the PyPI index should be reproducible on each
771771
# machine.
772-
return module_ctx.extension_metadata(reproducible = True)
772+
return module_ctx.extension_metadata(reproducible = False)
773773
else:
774774
return None
775775

0 commit comments

Comments
 (0)