incorporate feedback

Author: philsc

docs/toolchains.md

@@ -562,7 +562,7 @@ Currently the following flags are used to influence toolchain selection:
 
 To run the interpreter that Bazel will use, you can use the
 `@rules_python//python/bin:python` target. This is a binary target with
-the executable pointing at the `python3` binary plus the relevent runfiles.
+the executable pointing at the `python3` binary plus its relevent runfiles.
 
 ```console
 $ bazel run @rules_python//python/bin:python
@@ -596,5 +596,5 @@ a fixed version.
 
 :::{note}
 The `python` target does not provide access to any modules from `py_*`
-targets on its own. Work is ongoing to support that.
+targets on its own. Please file a feature request if this is desired.
 :::

python/bin/BUILD.bazel

@@ -1,16 +1,15 @@
-load(":interpreter.bzl", "interpreter")
-
-package(default_visibility = ["//visibility:public"])
+load("//python/private:interpreter.bzl", _interpreter_binary="interpreter_binary")
 
 filegroup(
     name = "distribution",
     srcs = glob(["**"]),
-    visibility = ["//python:__pkg__"],
+    visibility = ["//:__subpackages__"],
 )
 
-interpreter(
+_interpreter_binary(
     name = "python",
     binary = ":python_src",
+    visibility = ["//visibility:public"],
 )
 
 # The user can modify this flag to source different interpreters for the

python/bin/interpreter.bzl

@@ -19,7 +19,7 @@ load("//python:py_runtime_info.bzl", "PyRuntimeInfo")
 load(":sentinel.bzl", "SentinelInfo")
 load(":toolchain_types.bzl", "TARGET_TOOLCHAIN_TYPE")
 
-def _interpreter_impl(ctx):
+def _interpreter_binary_impl(ctx):
     if SentinelInfo in ctx.attr.binary:
         toolchain = ctx.toolchains[TARGET_TOOLCHAIN_TYPE]
         runtime = toolchain.py3_runtime
@@ -52,8 +52,8 @@ def _interpreter_impl(ctx):
         ),
     ]
 
-interpreter = rule(
-    implementation = _interpreter_impl,
+interpreter_binary = rule(
+    implementation = _interpreter_binary_impl,
     toolchains = [TARGET_TOOLCHAIN_TYPE],
     executable = True,
     attrs = {

python/private/interpreter.bzl

@@ -20,6 +20,7 @@
 
 class InterpreterTest(unittest.TestCase):
     def setUp(self):
+        super().setUp()
         self.interpreter = os.environ["PYTHON_BIN"]
 
     def test_self_version(self):