Skip to content

Commit 176b8ed

Browse files
committed
exp(pypi): enable pipstar by default on bzlmod
DO NOT MERGE: this is still a test
1 parent 5467ed6 commit 176b8ed

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ END_UNRELEASED_TEMPLATE
6969
* (bootstrap) For {obj}`--bootstrap_impl=system_python`, the sys.path order has
7070
changed from `[app paths, stdlib, runtime site-packages]` to `[stdlib, app
7171
paths, runtime site-packages]`.
72+
* (pypi) `pipstar` flag has been flipped to be enabled by default for bzlmod
73+
([#2949](https://github.com/bazel-contrib/rules_python/issues/2949)).
7274

7375
{#v0-0-0-fixed}
7476
### Fixed

python/private/internal_config_repo.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ settings for rules to later use.
2020

2121
load(":repo_utils.bzl", "repo_utils")
2222

23+
_BZLMOD_ENABLED = "@@" in str(Label("//:unused"))
2324
_ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
24-
_ENABLE_PIPSTAR_DEFAULT = "0"
25+
_ENABLE_PIPSTAR_DEFAULT = "1" if _BZLMOD_ENABLED else "0"
2526
_ENABLE_PYSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PYSTAR"
2627
_ENABLE_PYSTAR_DEFAULT = "1"
2728
_ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"

0 commit comments

Comments
 (0)