feat(pypi): enable pipstar by default on bzlmod

Extra fixes:
- add more logging to the failure
- better METADATA files in tests
- fix tests

Author: aignas

CHANGELOG.md

@@ -69,6 +69,8 @@ END_UNRELEASED_TEMPLATE
 * (bootstrap) For {obj}`--bootstrap_impl=system_python`, the sys.path order has
   changed from `[app paths, stdlib, runtime site-packages]` to `[stdlib, app
   paths, runtime site-packages]`.
+* (pypi) `pipstar` flag has been flipped to be enabled by default for bzlmod
+  ([#2949](https://github.com/bazel-contrib/rules_python/issues/2949)).
 
 {#v0-0-0-fixed}
 ### Fixed

python/private/internal_config_repo.bzl

@@ -20,8 +20,9 @@ settings for rules to later use.
 
 load(":repo_utils.bzl", "repo_utils")
 
+_BZLMOD_ENABLED = "@@" in str(Label("//:unused"))
 _ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
-_ENABLE_PIPSTAR_DEFAULT = "0"
+_ENABLE_PIPSTAR_DEFAULT = "1" if _BZLMOD_ENABLED else "0"
 _ENABLE_PYSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PYSTAR"
 _ENABLE_PYSTAR_DEFAULT = "1"
 _ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"

python/private/internal_dev_deps.bzl

@@ -40,6 +40,7 @@ def _internal_dev_deps_impl(mctx):
         name = "somepkg_with_build_files",
         whl_file = "@whl_with_build_files//:somepkg-1.0-any-none-any.whl",
         requirement = "somepkg",
+        dep_template = "@rules_python//tests/support:support.bzl",
     )
 
     # Setup for //tests/implicit_namespace_packages
@@ -53,6 +54,7 @@ def _internal_dev_deps_impl(mctx):
         whl_file = "@implicit_namespace_ns_sub1_whl//:ns_sub1-1.0-any-none-any.whl",
         requirement = "ns-sub1",
         enable_implicit_namespace_pkgs = False,
+        dep_template = "@rules_python//tests/support:support.bzl",
     )
 
     whl_from_dir_repo(
@@ -65,6 +67,7 @@ def _internal_dev_deps_impl(mctx):
         whl_file = "@implicit_namespace_ns_sub2_whl//:ns_sub2-1.0-any-none-any.whl",
         requirement = "ns-sub2",
         enable_implicit_namespace_pkgs = False,
+        dep_template = "@rules_python//tests/support:support.bzl",
     )
 
 internal_dev_deps = module_extension(

python/private/pypi/whl_metadata.bzl

@@ -26,7 +26,11 @@ def whl_metadata(*, install_dir, read_fn, logger):
     result = parse_whl_metadata(contents)
 
     if not (result.name and result.version):
-        logger.fail("Failed to parsed the wheel METADATA file:\n{}".format(contents))
+        logger.fail("Failed to parsed the wheel METADATA file:\n{}\n{}\n{}".format(
+            80 * "=",
+            contents.rstrip("\n"),
+            80 * "=",
+        ))
         return None
 
     return result

tests/implicit_namespace_packages/testdata/ns-sub1/ns-sub1-1.0.dist-info/METADATA

@@ -0,0 +1,2 @@
+Name: ns-sub1
+Version: 1.0

tests/implicit_namespace_packages/testdata/ns-sub2/ns_sub2-1.0.dist-info/METADATA

@@ -0,0 +1,2 @@
+Name: ns-sub2
+Version: 1.0

tests/support/support.bzl

@@ -22,6 +22,9 @@
 load("//python/private:bzlmod_enabled.bzl", "BZLMOD_ENABLED")  # buildifier: disable=bzl-visibility
 load("//python/private:util.bzl", "IS_BAZEL_7_OR_HIGHER")  # buildifier: disable=bzl-visibility
 
+# this is used in integration tests with `whl_library`
+whl_map = []
+
 MAC = Label("//tests/support:mac")
 MAC_X86_64 = Label("//tests/support:mac_x86_64")
 LINUX = Label("//tests/support:linux")

tests/whl_with_build_files/testdata/somepkg-1.0.dist-info/METADATA

@@ -0,0 +1,2 @@
+Name: somepkg
+Version: 1.0