move to templating part of the args

Author: aignas

python/uv/private/BUILD.bazel

@@ -15,6 +15,12 @@
 load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("//python:py_binary.bzl", "py_binary")
 
+exports_files(
+    srcs = ["pip_compile.py"],
+    # only because this is used from a macro to template
+    visibility = ["//visibility:public"],
+)
+
 filegroup(
     name = "distribution",
     srcs = glob(["**"]),

python/uv/private/lock.bzl

@@ -15,6 +15,7 @@
 """A simple macro to lock the requirements.
 """
 
+load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
 load("@bazel_skylib//rules:native_binary.bzl", "native_binary")
 load("@bazel_skylib//rules:write_file.bzl", "write_file")
 load("//python:py_binary.bzl", "py_binary")
@@ -27,7 +28,7 @@ _REQUIREMENTS_TARGET_COMPATIBLE_WITH = [] if BZLMOD_ENABLED else ["@platforms//:
 _RunLockInfo = provider(
     doc = "Information for running the underlying Sphinx command directly",
     fields = {
-        "locker": """
+        "cmd": """
 :type: Target
 
 The locker binary to run.
@@ -46,30 +47,29 @@ def _impl(ctx):
             ctx.files.src_outs[0].path,
         ])
     args.add("--output-file", ctx.outputs.out)
-    args.add_all(ctx.attr.args)
 
     # TODO @aignas 2025-03-02: add the following deps to _RunLockInfo
     srcs = ctx.files.srcs + ctx.files.src_outs
     args.add_all(ctx.files.srcs)
 
     ctx.actions.run(
-        executable = ctx.executable._locker,
+        executable = ctx.executable.cmd,
         mnemonic = "RulesPythonLock",
         inputs = srcs,
         outputs = [
             ctx.outputs.out,
         ],
         arguments = [args],
         tools = [
-            ctx.executable._locker,
+            ctx.executable.cmd,
         ],
         progress_message = "Locking requirements using uv",
         env = ctx.attr.env,
     )
 
     return [
         DefaultInfo(files = depset([ctx.outputs.out])),
-        _RunLockInfo(locker = ctx.executable._locker),
+        _RunLockInfo(cmd = ctx.executable.cmd),
     ]
 
 _lock = rule(
@@ -78,15 +78,15 @@ _lock = rule(
 """,
     attrs = {
         "args": attr.string_list(),
-        "env": attr.string_dict(),
-        "out": attr.output(mandatory = True),
-        "src_outs": attr.label_list(mandatory = True, allow_files = True),
-        "srcs": attr.label_list(mandatory = True, allow_files = True),
-        "_locker": attr.label(
+        "cmd": attr.label(
             default = "//python/uv/private:pip_compile",
             executable = True,
             cfg = "target",
         ),
+        "env": attr.string_dict(),
+        "out": attr.output(mandatory = True),
+        "src_outs": attr.label_list(mandatory = True, allow_files = True),
+        "srcs": attr.label_list(mandatory = True, allow_files = True),
     },
 )
 
@@ -130,6 +130,26 @@ def lock(*, name, srcs, out, args = [], **kwargs):
     ]
     args += user_args
 
+    expand_template(
+        name = name + "_locker_src",
+        out = name + "_locker.py",
+        template = "//python/uv/private:pip_compile.py",
+        substitutions = {
+            "    args = []": "    args = " + repr(args),
+        },
+        tags = ["manual"],
+    )
+
+    py_binary(
+        name = name + "_locker",
+        srcs = [name + "_locker.py"],
+        data = [
+            "//python/uv:current_toolchain",
+        ],
+        tags = ["manual"],
+        deps = ["//python/runfiles"],
+    )
+
     _lock(
         name = name,
         srcs = srcs,
@@ -145,6 +165,7 @@ def lock(*, name, srcs, out, args = [], **kwargs):
         ],
         args = args,
         target_compatible_with = _REQUIREMENTS_TARGET_COMPATIBLE_WITH,
+        cmd = name + "_locker",
     )
 
     run_args = []

python/uv/private/pip_compile.py

@@ -19,30 +19,33 @@ def _run() -> None:
     # Let `uv` know that it was spawned by this Python interpreter
     env["UV_INTERNAL__PARENT_INTERPRETER"] = sys.executable
     args = []
-    args += sys.argv[1:]
+    sys_args = sys.argv[1:]
 
-    src_out = args[1] if args[0] == "--src-out" else None
+    src_out = sys_args[1] if sys_args[0] == "--src-out" else None
     if src_out:
-        args = args[2:]
+        sys_args = sys_args[2:]
 
-    if args[0] != "--output-file":
+    if sys_args[0] != "--output-file":
         raise ValueError(
-            f"The first arg should be to declare the output file, got:\n{args}"
+            f"The first arg should be to declare the output file, got:\n{sys_args}"
         )
     else:
-        out = args[1]
+        out = sys_args[1]
 
+    srcs = sys_args[2:]
+
+    # this is set under bazel run
     workspace = env.get("BUILD_WORKSPACE_DIRECTORY")
     if workspace:
-        args[1] = Path(workspace) / out
+        dst = Path(workspace) / out
     elif src_out:
         src = Path(src_out)
         dst = Path(out)
         import shutil
 
         shutil.copy(src, dst)
 
-    uv_args = ["pip", "compile"] + args
+    uv_args = ["pip", "compile"] + args + srcs + ["--output-file", str(dst)]
 
     if sys.platform == "win32":
         import subprocess