Fixing compile pip requirements when running on an RBE

Author: shs96c

python/private/pypi/dependency_resolver/dependency_resolver.py

@@ -27,9 +27,9 @@
 
 from python.runfiles import runfiles
 
-# Replace the os.replace function with shutil.copy to work around os.replace not being able to
+# Replace the os.replace function with shutil.move to work around os.replace not being able to
 # replace or move files across filesystems.
-os.replace = shutil.copy
+os.replace = shutil.move
 
 # Next, we override the annotation_style_split and annotation_style_line functions to replace the
 # backslashes in the paths with forward slashes. This is so that we can have the same requirements

python/private/pypi/pip_compile.bzl

@@ -22,6 +22,8 @@ make it possible to have multiple tools inside the `pypi` directory
 load("//python:py_binary.bzl", _py_binary = "py_binary")
 load("//python:py_test.bzl", _py_test = "py_test")
 
+_DEFAULT_TAGS = ["no-sandbox", "no-remote-exec", "requires-network"]
+
 def pip_compile(
         name,
         srcs = None,
@@ -37,7 +39,7 @@ def pip_compile(
         requirements_linux = None,
         requirements_windows = None,
         visibility = ["//visibility:private"],
-        tags = None,
+        tags = _DEFAULT_TAGS,
         **kwargs):
     """Generates targets for managing pip dependencies with pip-compile.
 
@@ -76,6 +78,7 @@ def pip_compile(
         requirements_darwin: File of darwin specific resolve output to check validate if requirement.in has changes.
         requirements_windows: File of windows specific resolve output to check validate if requirement.in has changes.
         tags: tagging attribute common to all build rules, passed to both the _test and .update rules.
+            default: ["no-sandbox", "no-remote-exec", "requires-network"]
         visibility: passed to both the _test and .update rules.
         **kwargs: other bazel attributes passed to the "_test" rule.
     """
@@ -142,9 +145,6 @@ def pip_compile(
     ] + extra_deps
 
     tags = tags or []
-    tags.append("requires-network")
-    tags.append("no-remote-exec")
-    tags.append("no-sandbox")
     attrs = {
         "args": args,
         "data": data,