Skip to content

Commit 277089e

Browse files
authored
chore(deps): bump rules_cc to 0.1.5 (#3238)
This fixes an issue compiling protobuf on windows due to c++ 17 support. In particular, it gets the fix in bazelbuild/rules_cc@c7e5c8c which adds `/std:c++17` for Window builds. Fixes #3122
1 parent 4977221 commit 277089e

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ END_UNRELEASED_TEMPLATE
6161

6262
{#v0-0-0-changed}
6363
### Changed
64-
* Nothing changed.
64+
* (deps) bumped rules_cc dependency to `0.1.5`.
6565

6666
{#v0-0-0-fixed}
6767
### Fixed

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module(
66

77
bazel_dep(name = "bazel_features", version = "1.21.0")
88
bazel_dep(name = "bazel_skylib", version = "1.8.1")
9-
bazel_dep(name = "rules_cc", version = "0.0.16")
9+
bazel_dep(name = "rules_cc", version = "0.1.5")
1010
bazel_dep(name = "platforms", version = "0.0.11")
1111

1212
# Those are loaded only when using py_proto_library

internal_dev_deps.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,9 +233,9 @@ def rules_python_internal_deps():
233233

234234
http_archive(
235235
name = "rules_cc",
236-
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.16/rules_cc-0.0.16.tar.gz"],
237-
sha256 = "bbf1ae2f83305b7053b11e4467d317a7ba3517a12cef608543c1b1c5bf48a4df",
238-
strip_prefix = "rules_cc-0.0.16",
236+
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.1.5/rules_cc-0.1.5.tar.gz"],
237+
sha256 = "b8b918a85f9144c01f6cfe0f45e4f2838c7413961a8ff23bc0c6cdf8bb07a3b6",
238+
strip_prefix = "rules_cc-0.1.5",
239239
)
240240

241241
http_archive(

python/private/py_repositories.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ def py_repositories():
5959
)
6060
http_archive(
6161
name = "rules_cc",
62-
sha256 = "4b12149a041ddfb8306a8fd0e904e39d673552ce82e4296e96fac9cbf0780e59",
63-
strip_prefix = "rules_cc-0.1.0",
64-
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.1.0/rules_cc-0.1.0.tar.gz"],
62+
sha256 = "b8b918a85f9144c01f6cfe0f45e4f2838c7413961a8ff23bc0c6cdf8bb07a3b6",
63+
strip_prefix = "rules_cc-0.1.5",
64+
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.1.5/rules_cc-0.1.5.tar.gz"],
6565
)
6666

6767
# Needed by rules_cc, triggered by @rules_java_prebuilt in Bazel by using @rules_cc//cc:defs.bzl

tests/integration/local_toolchains/MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ module(name = "module_under_test")
1616
bazel_dep(name = "rules_python", version = "0.0.0")
1717
bazel_dep(name = "bazel_skylib", version = "1.7.1")
1818
bazel_dep(name = "platforms", version = "0.0.11")
19-
bazel_dep(name = "rules_cc", version = "0.0.16")
19+
bazel_dep(name = "rules_cc", version = "0.1.5")
2020

2121
local_path_override(
2222
module_name = "rules_python",

0 commit comments

Comments
 (0)