add unit tests

Author: aignas

python/private/pypi/pip_repository.bzl

@@ -92,16 +92,6 @@ def _pip_repository_impl(rctx):
             requirements_osx = rctx.attr.requirements_darwin,
             requirements_windows = rctx.attr.requirements_windows,
             extra_pip_args = rctx.attr.extra_pip_args,
-            platforms = [
-                "linux_aarch64",
-                "linux_arm",
-                "linux_ppc",
-                "linux_s390x",
-                "linux_x86_64",
-                "osx_aarch64",
-                "osx_x86_64",
-                "windows_x86_64",
-            ],
         ),
         extra_pip_args = rctx.attr.extra_pip_args,
         evaluate_markers = lambda rctx, requirements: evaluate_markers_py(

python/private/pypi/requirements_files_by_platform.bzl

@@ -96,7 +96,17 @@ def requirements_files_by_platform(
         requirements_linux = None,
         requirements_lock = None,
         requirements_windows = None,
-        platforms,
+        platforms = [],
+        default_platforms = [
+            "linux_aarch64",
+            "linux_arm",
+            "linux_ppc",
+            "linux_s390x",
+            "linux_x86_64",
+            "osx_aarch64",
+            "osx_x86_64",
+            "windows_x86_64",
+        ],
         extra_pip_args = None,
         python_version = None,
         logger = None,
@@ -117,6 +127,8 @@ def requirements_files_by_platform(
             specified. It should be of the form "3.x.x",
         platforms: {type}`list[str]` the list of human-friendly platform labels that should
             be used for the evaluation.
+        default_platforms: {type}`list[str]` the list of human-friendly platform labels
+            that will be used for wildcard evaluation.
         logger: repo_utils.logger or None, a simple struct to log diagnostic messages.
         fail_fn (Callable[[str], None]): A failure function used in testing failure cases.
 
@@ -142,7 +154,10 @@ def requirements_files_by_platform(
     if logger:
         logger.debug(lambda: "Platforms from pip args: {}".format(platforms_from_args))
 
-    default_platforms = platforms
+    default_platforms = [_platform(p, python_version) for p in default_platforms]
+    platforms = platforms or default_platforms
+    platforms = [_platform(p, python_version) for p in platforms]
+    default_platforms = [p for p in default_platforms if p in platforms]
 
     if platforms_from_args:
         lock_files = [

tests/pypi/requirements_files_by_platform/requirements_files_by_platform_tests.bzl

@@ -103,6 +103,33 @@ def _test_simple(env):
 
 _tests.append(_test_simple)
 
+def _test_simple_default_platforms(env):
+    default_platforms = [
+        "linux_aarch64",
+        "linux_x86_64",
+        "osx_aarch64",
+        "windows_x86_64",
+    ]
+    for got in [
+        requirements_files_by_platform(
+            requirements_lock = "requirements_lock",
+            default_platforms = default_platforms,
+            platforms = [],
+        ),
+        requirements_files_by_platform(
+            requirements_by_platform = {
+                "requirements_lock": "*",
+            },
+            default_platforms = default_platforms,
+            platforms = [],
+        ),
+    ]:
+        env.expect.that_dict(got).contains_exactly({
+            "requirements_lock": default_platforms,
+        })
+
+_tests.append(_test_simple_default_platforms)
+
 def _test_simple_limited(env):
     for got in [
         requirements_files_by_platform(