Skip to content

Commit 2b5808e

Browse files
authored
rename tests to better describe what they're testing
1 parent 0a9e1aa commit 2b5808e

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/base_rules/py_executable_base_tests.bzl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -342,51 +342,51 @@ def _test_name_cannot_end_in_py_impl(env, target):
342342
matching.str_matches("name must not end in*.py"),
343343
)
344344

345-
def _test_no_srcs(name, config):
345+
def _test_main_module_bootstrap_system_python(name, config):
346346
rt_util.helper_target(
347347
config.rule,
348348
name = name + "_subject",
349349
main_module = "dummy",
350350
)
351351
analysis_test(
352352
name = name,
353-
impl = _test_no_srcs_impl,
353+
impl = _test_main_module_bootstrap_system_python_impl,
354354
target = name + "_subject",
355355
config_settings = {
356356
"//command_line_option:platforms": [LINUX_X86_64],
357357
},
358358
expect_failure = True,
359359
)
360360

361-
def _test_no_srcs_impl(env, target):
361+
def _test_main_module_bootstrap_system_python_impl(env, target):
362362
env.expect.that_target(target).failures().contains_predicate(
363363
matching.str_matches("mandatory*srcs"),
364364
)
365365

366-
_tests.append(_test_no_srcs)
366+
_tests.append(_test_main_module_bootstrap_system_python)
367367

368-
def _test_no_srcs_script_bootstrap(name, config):
368+
def _test_main_module_bootstrap_script(name, config):
369369
rt_util.helper_target(
370370
config.rule,
371371
name = name + "_subject",
372372
main_module = "dummy",
373373
)
374374
analysis_test(
375375
name = name,
376-
impl = _test_no_srcs_script_bootstrap_impl,
376+
impl = _test_main_module_bootstrap_script_impl,
377377
target = name + "_subject",
378378
config_settings = {
379379
BOOTSTRAP_IMPL: "script",
380380
"//command_line_option:platforms": [LINUX_X86_64],
381381
},
382382
)
383383

384-
def _test_no_srcs_script_bootstrap_impl(env, target):
384+
def _test_main_module_bootstrap_script_impl(env, target):
385385
env.expect.that_target(target).default_outputs().contains(
386386
"{package}/{test_name}_subject",
387387
)
388388

389-
_tests.append(_test_no_srcs_script_bootstrap)
389+
_tests.append(_test_main_module_bootstrap_script)
390390

391391
def _test_py_runtime_info_provided(name, config):
392392
rt_util.helper_target(

0 commit comments

Comments
 (0)