Skip to content

Commit 2ee0e92

Browse files
committed
Add libs/python3.lib to libpython target for SABI builds on Windows
When targeting the Python Stable ABI on Windows (by setting the Py_LIMITED_API macro to a Python minimum version hex), the unversioned python3.lib needs to be linked instead of the versioned one (e.g. python38.lib for Python 3.8). Python's own config sets the library to link by default in a header called pyconfig.h (https://github.com/python/cpython/blob/9cc9e277254023c0ca08e1a9e379fd89475ca9c2/PC/pyconfig.h#L270), which prompts the linker to search for python3.lib if a stable ABI extension is built using `@rules_python` toolchains. Since this library is not exported on Windows in the `python_repository()` rule, it's added now to allow Python SABI extensions to be built (and linked) on Windows with `@rules_python`. Since Python takes responsibility for linking the correct lib on Windows, and never both at the same time, no other changes are made.
1 parent 9e38b65 commit 2ee0e92

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ A brief description of the categories of changes:
4242
`pip.parse` extension is now possible, see the
4343
`examples/pip_parse/MODULE.bazel` for how to do it.
4444
See [#1371](https://github.com/bazelbuild/rules_python/issues/1371).
45+
* (repositories): Add libs/python3.lib and pythonXY.dll to the `libpython` target
46+
defined by a repository template. This enables stable ABI builds of Python extensions
47+
on Windows (by defining Py_LIMITED_API).
4548

4649
### Added
4750

python/repositories.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ cc_library(
319319
name = "libpython",
320320
hdrs = [":includes"],
321321
srcs = select({{
322-
"@platforms//os:windows": ["python3.dll", "libs/python{python_version_nodot}.lib"],
322+
"@platforms//os:windows": ["python3.dll", "python{python_version_nodot}.dll", "libs/python3.lib", "libs/python{python_version_nodot}.lib"],
323323
"@platforms//os:macos": ["lib/libpython{python_version}.dylib"],
324324
"@platforms//os:linux": ["lib/libpython{python_version}.so", "lib/libpython{python_version}.so.1.0"],
325325
}}),

0 commit comments

Comments
 (0)