Skip to content

Commit 2fc298b

Browse files
authored
Clarify comment about fallback behavior
1 parent 28ff6be commit 2fc298b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

python/private/pypi/pep508_evaluate.bzl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,9 @@ def _version_expr(left, op, right):
366366
_left = parse_version(left)
367367
_right = parse_version(right)
368368
if _left == None or _right == None:
369-
# Sometimes `platform_version` is not a true PEP440 version,
370-
# so then we fallback to a simple string expression evaluation
369+
# Per spec, if either can't be normalized to a version, then
370+
# fallback to simple string comparison. Usually this is `platform_version`
371+
# or `platform_release`, which vary depending on platform.
371372
return _env_expr(left, op, right)
372373

373374
if op == "<":

0 commit comments

Comments
 (0)