Update with py_binary kind only

Author: yushan8

gazelle/python/generate.go

@@ -32,6 +32,7 @@ import (
 	"github.com/emirpasic/gods/sets/treeset"
 	godsutils "github.com/emirpasic/gods/utils"
 
+
 	"github.com/bazel-contrib/rules_python/gazelle/pythonconfig"
 )
 
@@ -492,18 +493,28 @@ func (py *Python) getRulesWithInvalidSrcs(args language.GenerateArgs) (invalidRu
 	if args.File == nil {
 		return
 	}
-	regularFiles := args.RegularFiles
-	regularFilesMap := make(map[string]struct{})
-	for _, file := range regularFiles {
-		regularFilesMap[file] = struct{}{}
+	filesMap := make(map[string]struct{})
+	for _, file := range args.RegularFiles {
+		filesMap[file] = struct{}{}
+	}
+	for _, file := range args.GenFiles {
+		filesMap[file] = struct{}{}
+	}
+
+	isTarget := func(src string) bool {
+		return strings.HasPrefix(src, "@") || strings.HasPrefix(src, "//") || strings.HasPrefix(src, ":")
 	}
 	for _, existingRule := range args.File.Rules {
-		if _, ok := py.Kinds()[existingRule.Kind()]; !ok {
+		if existingRule.Kind() != pyBinaryKind {
 			continue
 		}
 		allInvalidSrcs := true
 		for _, src := range existingRule.AttrStrings("srcs") {
-			if _, ok := regularFilesMap[src]; ok {
+			if _, ok := filesMap[src]; ok {
+				allInvalidSrcs = false
+				break
+			}
+			if isTarget(src) {
 				allInvalidSrcs = false
 				break
 			}
@@ -514,6 +525,7 @@ func (py *Python) getRulesWithInvalidSrcs(args language.GenerateArgs) (invalidRu
 	}
 	return invalidRules
 }
+
 // isBazelPackage determines if the directory is a Bazel package by probing for
 // the existence of a known BUILD file name.
 func isBazelPackage(dir string) bool {

gazelle/python/testdata/remove_invalid_binary/keep_binary/BUILD.in

@@ -0,0 +1,5 @@
+py_binary(
+    name = "keep_target_binary",
+    srcs = ["//test/binary:__main__.py"],
+    visibility = ["//:__subpackages__"],
+)

gazelle/python/testdata/remove_invalid_binary/keep_binary/BUILD.out

@@ -0,0 +1,5 @@
+py_binary(
+    name = "keep_target_binary",
+    srcs = ["//test/binary:__main__.py"],
+    visibility = ["//:__subpackages__"],
+)

gazelle/python/testdata/remove_invalid_library/BUILD.out

@@ -0,0 +1,10 @@
+load("@rules_python//python:defs.bzl", "py_library")
+
+py_library(
+    name = "deps_with_no_srcs_library",
+    deps = [
+        "//:remove_invalid_library",
+        "@pypi//bar",
+        "@pypi//foo",
+    ],
+)