Skip to content

Commit 39f5ea9

Browse files
committed
cleanup, disable skip in local_toolchains integration test
1 parent 3ce45c3 commit 39f5ea9

File tree

2 files changed

+7
-18
lines changed

2 files changed

+7
-18
lines changed

tests/integration/local_toolchains/BUILD.bazel

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ py_test(
2323
# NOTE: This isn't strictly correct because is_toolchain_py39plus
2424
# ends up using the config state coming into the target, not from within
2525
# the target. There's no transitions going on, though, so it works OK.
26-
target_compatible_with = select({
27-
# Our RBE's system python is 3.6, which is too old.
28-
":is_toolchain_py39plus": [],
29-
"//conditions:default": ["@platforms//:incompatible"],
30-
}),
26+
##target_compatible_with = select({
27+
## # Our RBE's system python is 3.6, which is too old.
28+
## ":is_toolchain_py39plus": [],
29+
## "//conditions:default": ["@platforms//:incompatible"],
30+
##}),
3131
)
3232

3333
config_setting(

tests/runtime_env_toolchain/BUILD.bazel

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,8 @@ py_reconfig_test(
3030
CC_TOOLCHAIN,
3131
],
3232
main = "toolchain_runs_test.py",
33-
# Doesn't work -- doesn't have ConstraintValueInfo provider?
34-
#target_compatible_with = [
35-
# "@platforms//host",
36-
#],
37-
# Doesn't work -- not a valid select condition?
38-
#target_compatible_with = select({
39-
# "@platforms//host": [],
40-
# "//conditions:default": ["@platforms//:incompatible"],
41-
#}),
42-
##target_compatible_with = select({
43-
## ":is_host": [],
44-
## "//conditions:default": ["@platforms//:incompatible"],
45-
##}),
33+
# Our RBE has Python 3.6, which is too old for the language features
34+
# we use now.
4635
tags = ["no-remote-exec"],
4736
deps = ["//python/runfiles"],
4837
)

0 commit comments

Comments
 (0)