Skip to content

Commit 3d4b697

Browse files
committed
remove unused values from the config constructor
1 parent be0144c commit 3d4b697

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

python/private/pypi/extension.bzl

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -392,15 +392,6 @@ def _whl_repos(*, requirement, whl_library_args, download_only, netrc, auth_patt
392392

393393
def _configure(config, *, platform, constraint_values, target_settings, os_name, arch_name, override = False, **values):
394394
"""Set the value in the config if the value is provided"""
395-
for key, value in values.items():
396-
if not value:
397-
continue
398-
399-
if not override and config.get(key):
400-
continue
401-
402-
config[key] = value
403-
404395
config.setdefault("platforms", {})
405396
if not platform:
406397
if constraint_values or target_settings:
@@ -453,6 +444,7 @@ def parse_modules(
453444
defaults,
454445
arch_name = tag.arch_name,
455446
constraint_values = tag.constraint_values,
447+
# The env_ values is only used if the `PIPSTAR` is enabled
456448
env_implementation_name = tag.env_implementation_name,
457449
env_os_name = tag.env_os_name,
458450
env_platform_machine = tag.env_platform_machine,

0 commit comments

Comments
 (0)