Skip to content

Commit 3ea01bb

Browse files
committed
address comments and add docs
1 parent 85acec5 commit 3ea01bb

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

.github/workflows/mypy.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
---
21
name: mypy
32

43
on:

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,13 @@ Unreleased changes template.
8181
[PR #2746](https://github.com/bazel-contrib/rules_python/pull/2746).
8282
* (rules) {attr}`py_binary.srcs` and {attr}`py_test.srcs` is no longer mandatory when
8383
`main_module` is specified (for `--bootstrap_impl=script`)
84+
* (pypi) From now on the `Requires-Dist` from the wheel metadata is analysed in
85+
the loading phase instead of repository rule phase giving better caching
86+
performance when the target platforms are changed (e.g. target python
87+
versions). This is preparatory work for stabilizing the cross-platform wheel
88+
support. From now on the usage of `experimental_target_platforms` should be
89+
avoided and the `requirements_by_platform` values should be instead used to
90+
specify the target platforms for the given dependencies.
8491

8592
[20250317]: https://github.com/astral-sh/python-build-standalone/releases/tag/20250317
8693

python/private/pypi/attrs.bzl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,9 @@ Warning:
123123
"experimental_target_platforms": attr.string_list(
124124
default = [],
125125
doc = """\
126+
*NOTE*: This will be removed in the next major version, so please consider migrating
127+
to `bzlmod` and rely on {attr}`pip.parse.requirements_by_platform` for this feature.
128+
126129
A list of platforms that we will generate the conditional dependency graph for
127130
cross platform wheels by parsing the wheel metadata. This will generate the
128131
correct dependencies for packages like `sphinx` or `pylint`, which include

0 commit comments

Comments
 (0)