Skip to content

Commit 3ecc713

Browse files
committed
reword comments on the future
1 parent c459371 commit 3ecc713

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

python/private/pypi/extension.bzl

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -505,10 +505,12 @@ You cannot use both the additive_build_content and additive_build_content_file a
505505
platform = tag.platform,
506506
override = mod.is_root,
507507
# TODO @aignas 2025-05-19: add more attr groups:
508-
# * for AUTH
509-
# * for index config
510-
# * for whl selection
511-
# * for custom platform definition
508+
# * for AUTH - the default `netrc` usage could be configured through a common
509+
# attribute.
510+
# * for index/downloader config. This includes all of those attributes for
511+
# overrides, etc. Index overrides per platform could be also used here.
512+
# * for whl selection - selecting preferences of which `platform_tag`s we should use
513+
# for what. We could also model the `cp313t` freethreaded as separate platforms.
512514
)
513515

514516
config = _create_config(defaults)

python/private/pypi/requirements_files_by_platform.bzl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ def requirements_files_by_platform(
113113
be joined with args fined in files.
114114
python_version: str or None. This is needed when the get_index_urls is
115115
specified. It should be of the form "3.x.x",
116-
platforms: TODO
116+
platforms: {type}`list[str]` the list of human-friendly platform labels that should
117+
be used for the evaluation.
117118
logger: repo_utils.logger or None, a simple struct to log diagnostic messages.
118119
fail_fn (Callable[[str], None]): A failure function used in testing failure cases.
119120
@@ -137,7 +138,7 @@ def requirements_files_by_platform(
137138

138139
platforms_from_args = _platforms_from_args(extra_pip_args)
139140
if logger:
140-
logger.debug(lambda: "Platforms from pip args: {}".format(platforms))
141+
logger.debug(lambda: "Platforms from pip args: {}".format(platforms_from_args))
141142

142143
default_platforms = [_platform(p, python_version) for p in platforms]
143144

0 commit comments

Comments
 (0)